Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

2015-07-10 Thread Scott Wood
On Fri, 2015-07-10 at 15:57 -0500, Pledge Roy-R01356 wrote: > > > > On Fri, 2015-07-10 at 13:36 +0200, Paul Bolle wrote: > > > On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote: > > > > +#ifdef CONFIG_FSL_DPA_CHECKING > > > > +#define DPA_ASSERT(x) \ > > > > + do { \ > > > > + if (!(x

RE: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

2015-07-10 Thread Roy Pledge
> > On Fri, 2015-07-10 at 13:36 +0200, Paul Bolle wrote: > > On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote: > > > +#ifdef CONFIG_FSL_DPA_CHECKING > > > +#define DPA_ASSERT(x) \ > > > + do { \ > > > + if (!(x)) { \ > > > + pr_crit("ASSERT: (%s:%d) %s\n", __FILE__,

Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

2015-07-10 Thread Scott Wood
On Fri, 2015-07-10 at 13:29 -0500, Pledge Roy-R01356 wrote: > > return in_be32((void *)bm + offset); > > > ^ > > > [...]/drivers/soc/fsl/qbman/bman.c: In function ‘__bm_out’: > > > [...]/drivers/soc/fsl/qbman/bman.c:172:2: error: implicit declaration > > > of function ‘out_be32’ [-Werror

RE: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

2015-07-10 Thread Roy Pledge
> return in_be32((void *)bm + offset); > > ^ > > [...]/drivers/soc/fsl/qbman/bman.c: In function ‘__bm_out’: > > [...]/drivers/soc/fsl/qbman/bman.c:172:2: error: implicit declaration > > of function ‘out_be32’ [-Werror=implicit-function-declaration] > > out_be32((void *)bm + offset, va

Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

2015-07-10 Thread Scott Wood
On Fri, 2015-07-10 at 13:36 +0200, Paul Bolle wrote: > On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote: > > +#ifdef CONFIG_FSL_DPA_CHECKING > > +#define DPA_ASSERT(x) \ > > + do { \ > > + if (!(x)) { \ > > + pr_crit("ASSERT: (%s:%d) %s\n", __FILE__, __LINE__, \ > >

Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

2015-07-10 Thread Scott Wood
On Fri, 2015-07-10 at 10:38 +0200, Paul Bolle wrote: > On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote: > > --- /dev/null > > +++ b/drivers/soc/fsl/qbman/Kconfig > > @@ -0,0 +1,33 @@ > > +menuconfig FSL_DPA > > + bool "Freescale DPAA support" > > + depends on FSL_SOC || COMPILE_TEST > > Are

Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

2015-07-10 Thread Paul Bolle
On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote: > --- /dev/null > +++ b/drivers/soc/fsl/qbman/Kconfig > +menuconfig FSL_DPA > + bool "Freescale DPAA support" > + depends on FSL_SOC || COMPILE_TEST (I already commented on COMPILE_TEST in a separate mail.) > + default n > + hel

Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

2015-07-10 Thread Paul Bolle
On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote: > --- /dev/null > +++ b/drivers/soc/fsl/qbman/Kconfig > @@ -0,0 +1,33 @@ > +menuconfig FSL_DPA > + bool "Freescale DPAA support" > + depends on FSL_SOC || COMPILE_TEST Are you sure about COMPILE_TEST? > + default n > + help > +

[PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

2015-07-09 Thread Roy Pledge
From: Geoff Thorpe This driver enables the Freescale DPAA 1.0 Buffer Manager block. BMan is a hardware buffer pool manager that allows accelerators connected to the SoC datapath to acquire and release buffers during data processing. Signed-off-by: Geoff Thorpe Signed-off-by: Emil Medve Signed-