Re: [Resend(2)] [PATCH 01/05] ipv6: RFC4214 Support (4)

2007-11-13 Thread Stephen Hemminger
> +#if defined(CONFIG_IPV6_ISATAP) > +/* only for IFF_ISATAP interfaces */ > +static inline int ipv6_addr_is_isatap(const struct in6_addr *addr) > +{ > + return ((addr->s6_addr32[2] | htonl(0x0200)) == > htonl(0x02005EFE)); > +} > +#endif > + No need to make this conditional, unless yo

RE: [Resend][PATCH 01/05] ipv6: RFC4214 Support (4)

2007-11-12 Thread Templin, Fred L
> Ok, thanks for the explanation. One questions is though why > do we need all the #if defines() throughout the file? Was just trying to follow what I thought was convention, but I'm willing to be educated... > Most distros end up enabled almost everything anyway. Looking > at the code, there i

Re: [Resend][PATCH 01/05] ipv6: RFC4214 Support (4)

2007-11-12 Thread Vlad Yasevich
Hi Fred Templin, Fred L wrote: > Vlad, > > Yes, I was breaking into multiples to ease review only. > The "[PATCH 01/04] ... (5)" thread includes the complete > reviewable and patchable final text in 4 files. In my > next message, I will put the entire patchfile as inline > text. (The "[PATCH 01/0

RE: [Resend][PATCH 01/05] ipv6: RFC4214 Support (4)

2007-11-12 Thread Templin, Fred L
#x27;iproute2' is already complete.) Thanks - Fred [EMAIL PROTECTED] > -Original Message- > From: Vlad Yasevich [mailto:[EMAIL PROTECTED] > Sent: Monday, November 12, 2007 2:11 PM > To: Templin, Fred L > Cc: netdev@vger.kernel.org; [EMAIL PROTECTED] > Subject: Re: [Resend

Re: [Resend][PATCH 01/05] ipv6: RFC4214 Support (4)

2007-11-12 Thread Vlad Yasevich
wrote: > > > -Original Message- > From: osprey67 [mailto:[EMAIL PROTECTED] > Sent: Monday, November 12, 2007 7:54 AM > To: netdev@vger.kernel.org > Subject: [PATCH 01/05] ipv6: RFC4214 Support (4) > > From: Fred L. Templin <[EMAIL PROTECTED]> > > Thi

[Resend(2)] [PATCH 01/05] ipv6: RFC4214 Support (4)

2007-11-12 Thread Templin, Fred L
-Original Message- From: osprey67 [mailto:[EMAIL PROTECTED] Sent: Monday, November 12, 2007 7:54 AM To: netdev@vger.kernel.org Subject: [PATCH 01/05] ipv6: RFC4214 Support (4) From: Fred L. Templin <[EMAIL PROTECTED]> This is experimental support for the Intra-Site Automatic

[Resend][PATCH 01/05] ipv6: RFC4214 Support (4)

2007-11-12 Thread Templin, Fred L
-Original Message- From: osprey67 [mailto:[EMAIL PROTECTED] Sent: Monday, November 12, 2007 7:54 AM To: netdev@vger.kernel.org Subject: [PATCH 01/05] ipv6: RFC4214 Support (4) From: Fred L. Templin <[EMAIL PROTECTED]> This is experimental support for the Intra-Site Automatic

[PATCH 01/05] ipv6: RFC4214 Support (4)

2007-11-12 Thread osprey67
From: Fred L. Templin <[EMAIL PROTECTED]> This is experimental support for the Intra-Site Automatic Tunnel Addressing Protocol (ISATAP) per RFC4214. It uses the SIT module, and is configured using the unmodified "ip" utility with device names beginning with: "isatap". The following diffs are spe