Re: [PATCH 01/02] change fwmark code to document use of attribute

2006-02-21 Thread jamal
On Tue, 2006-21-02 at 13:17 +1100, Herbert Xu wrote: > Michael Richardson <[EMAIL PROTECTED]> wrote: > > I'll regenerate the patch? Who is the prime on this file? > > Send all networking patches to [EMAIL PROTECTED] with a cc to > this list. Michael, The comments from Patrick are also valuable.

Re: [PATCH 01/02] change fwmark code to document use of attribute

2006-02-20 Thread Herbert Xu
Michael Richardson <[EMAIL PROTECTED]> wrote: > I'll regenerate the patch? Who is the prime on this file? Send all networking patches to [EMAIL PROTECTED] with a cc to this list. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: ht

Re: [PATCH 01/02] change fwmark code to document use of attribute

2006-02-20 Thread Michael Richardson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > "Herbert" == Herbert Xu <[EMAIL PROTECTED]> writes: >> +#define RTA_FWMARK RTA_PROTOINFO Herbert> How about doing it inside the enum as Herbert> RTA_FWMARK = RTA_PROTOINFO, I'm happy with that. I guess that's the style further

Re: [PATCH 01/02] change fwmark code to document use of attribute

2006-02-20 Thread Herbert Xu
Michael Richardson <[EMAIL PROTECTED]> wrote: > diff --git a/include/linux/rtnetlink.h b/include/linux/rtnetlink.h > index d50482b..27fd17e 100644 > --- a/include/linux/rtnetlink.h > +++ b/include/linux/rtnetlink.h > @@ -257,7 +257,7 @@ enum rtattr_type_t >RTA_PREFSRC, >RTA_METRICS,

[PATCH 01/02] change fwmark code to document use of attribute

2006-02-20 Thread Michael Richardson
the ip rule functions do not declare their own message attributes for fwmark functionality, but rather (ab)use attributes defined for other purposes. This patch just better abstracts the relationship and documents it with a #define Sign-off-by: Michael Richardson <[EMAIL PROTECTED]> --- inclu