Re: [PATCH 00/15] net: taint when the device driver firmware crashes

2020-05-11 Thread Steven Rostedt
On Sat, 9 May 2020 18:01:51 -0700 Shannon Nelson wrote: > If the driver is able to detect that the device firmware has come back > alive, through user intervention or whatever, should there be a way to > "untaint" the kernel?  Or would you expect it to remain tainted? The only way to untaint a

Re: [PATCH 00/15] net: taint when the device driver firmware crashes

2020-05-11 Thread Luis Chamberlain
On Sat, May 09, 2020 at 07:15:23PM -0700, Shannon Nelson wrote: > On 5/9/20 6:58 PM, Andrew Lunn wrote: > > On Sat, May 09, 2020 at 06:01:51PM -0700, Shannon Nelson wrote: > > As for firmware, how much damage can the firmware do as it crashed? If > > it is a DMA master, it could of splattered stuff

Re: [PATCH 00/15] net: taint when the device driver firmware crashes

2020-05-11 Thread Luis Chamberlain
On Sat, May 09, 2020 at 11:35:46AM -0700, Jakub Kicinski wrote: > On Sat, 9 May 2020 04:35:37 + Luis Chamberlain wrote: > > Device driver firmware can crash, and sometimes, this can leave your > > system in a state which makes the device or subsystem completely > > useless. Detecting this by i

Re: [PATCH 00/15] net: taint when the device driver firmware crashes

2020-05-09 Thread Shannon Nelson
On 5/9/20 6:58 PM, Andrew Lunn wrote: On Sat, May 09, 2020 at 06:01:51PM -0700, Shannon Nelson wrote: On 5/8/20 9:35 PM, Luis Chamberlain wrote: Device driver firmware can crash, and sometimes, this can leave your system in a state which makes the device or subsystem completely useless. Detecti

Re: [PATCH 00/15] net: taint when the device driver firmware crashes

2020-05-09 Thread Andrew Lunn
On Sat, May 09, 2020 at 06:01:51PM -0700, Shannon Nelson wrote: > On 5/8/20 9:35 PM, Luis Chamberlain wrote: > > Device driver firmware can crash, and sometimes, this can leave your > > system in a state which makes the device or subsystem completely > > useless. Detecting this by inspecting /proc/

Re: [PATCH 00/15] net: taint when the device driver firmware crashes

2020-05-09 Thread Shannon Nelson
On 5/8/20 9:35 PM, Luis Chamberlain wrote: Device driver firmware can crash, and sometimes, this can leave your system in a state which makes the device or subsystem completely useless. Detecting this by inspecting /proc/sys/kernel/tainted instead of scraping some magical words from the kernel lo

Re: [PATCH 00/15] net: taint when the device driver firmware crashes

2020-05-09 Thread Jakub Kicinski
On Sat, 9 May 2020 04:35:37 + Luis Chamberlain wrote: > Device driver firmware can crash, and sometimes, this can leave your > system in a state which makes the device or subsystem completely > useless. Detecting this by inspecting /proc/sys/kernel/tainted instead > of scraping some magical wo

[PATCH 00/15] net: taint when the device driver firmware crashes

2020-05-08 Thread Luis Chamberlain
Device driver firmware can crash, and sometimes, this can leave your system in a state which makes the device or subsystem completely useless. Detecting this by inspecting /proc/sys/kernel/tainted instead of scraping some magical words from the kernel log, which is driver specific, is much easier.