Re: [PATCH 00/11] XDP unaligned chunk placement support

2019-07-02 Thread Jonathan Lemon
; Karlsson, Magnus ; b...@vger.kernel.org; intel-wired-...@lists.osuosl.org; Richardson, Bruce ; Loftus, Ciara Subject: Re: [PATCH 00/11] XDP unaligned chunk placement support On Mon, 1 Jul 2019 15:44:29 +0100, Laatz, Kevin wrote: On 28/06/2019 21:29, Jonathan Lemon wrote: On 28 Jun 2019, at 9:19

RE: [PATCH 00/11] XDP unaligned chunk placement support

2019-07-02 Thread Richardson, Bruce
gt; b...@vger.kernel.org; intel-wired-...@lists.osuosl.org; Richardson, Bruce > ; Loftus, Ciara > Subject: Re: [PATCH 00/11] XDP unaligned chunk placement support > > On Mon, 1 Jul 2019 15:44:29 +0100, Laatz, Kevin wrote: > > On 28/06/2019 21:29, Jonathan Lemon wrote: > &g

Re: [PATCH 00/11] XDP unaligned chunk placement support

2019-07-01 Thread Jakub Kicinski
On Mon, 1 Jul 2019 15:44:29 +0100, Laatz, Kevin wrote: > On 28/06/2019 21:29, Jonathan Lemon wrote: > > On 28 Jun 2019, at 9:19, Laatz, Kevin wrote: > >> On 27/06/2019 22:25, Jakub Kicinski wrote: > >>> I think that's very limiting.  What is the challenge in providing > >>> aligned addresses, e

Re: [PATCH 00/11] XDP unaligned chunk placement support

2019-07-01 Thread Laatz, Kevin
On 28/06/2019 21:29, Jonathan Lemon wrote: On 28 Jun 2019, at 9:19, Laatz, Kevin wrote: On 27/06/2019 22:25, Jakub Kicinski wrote: I think that's very limiting.  What is the challenge in providing aligned addresses, exactly? The challenges are two-fold: 1) it prevents using arbitrary buffer si

Re: [PATCH 00/11] XDP unaligned chunk placement support

2019-06-28 Thread Jonathan Lemon
On 28 Jun 2019, at 9:19, Laatz, Kevin wrote: On 27/06/2019 22:25, Jakub Kicinski wrote: On Thu, 27 Jun 2019 12:14:50 +0100, Laatz, Kevin wrote: On the application side (xdpsock), we don't have to worry about the user defined headroom, since it is 0, so we only need to account for the XDP_P

Re: [PATCH 00/11] XDP unaligned chunk placement support

2019-06-28 Thread Jakub Kicinski
On Fri, 28 Jun 2019 17:19:09 +0100, Laatz, Kevin wrote: > On 27/06/2019 22:25, Jakub Kicinski wrote: > > On Thu, 27 Jun 2019 12:14:50 +0100, Laatz, Kevin wrote: > >> On the application side (xdpsock), we don't have to worry about the user > >> defined headroom, since it is 0, so we only need to a

Re: [PATCH 00/11] XDP unaligned chunk placement support

2019-06-28 Thread Jakub Kicinski
On Fri, 28 Jun 2019 18:51:37 +0200, Björn Töpel wrote: > In your example Jakub, how would this look in XDP? Wouldn't the > timestamp be part of the metadata (xdp_md.data_meta)? Isn't > data-data_meta (if valid) <= XDP_PACKET_HEADROOM? That was my assumption. The driver parses the metadata and copi

Re: [PATCH 00/11] XDP unaligned chunk placement support

2019-06-28 Thread Björn Töpel
On 2019-06-28 18:19, Laatz, Kevin wrote: On 27/06/2019 22:25, Jakub Kicinski wrote: On Thu, 27 Jun 2019 12:14:50 +0100, Laatz, Kevin wrote: On the application side (xdpsock), we don't have to worry about the user defined headroom, since it is 0, so we only need to account for the XDP_PACKET_HEA

Re: [PATCH 00/11] XDP unaligned chunk placement support

2019-06-28 Thread Laatz, Kevin
On 27/06/2019 22:25, Jakub Kicinski wrote: On Thu, 27 Jun 2019 12:14:50 +0100, Laatz, Kevin wrote: On the application side (xdpsock), we don't have to worry about the user defined headroom, since it is 0, so we only need to account for the XDP_PACKET_HEADROOM when computing the original address

Re: [PATCH 00/11] XDP unaligned chunk placement support

2019-06-27 Thread Jakub Kicinski
On Thu, 27 Jun 2019 12:14:50 +0100, Laatz, Kevin wrote: > On the application side (xdpsock), we don't have to worry about the user > defined headroom, since it is 0, so we only need to account for the > XDP_PACKET_HEADROOM when computing the original address (in the default > scenario). That as

Re: [PATCH 00/11] XDP unaligned chunk placement support

2019-06-27 Thread Laatz, Kevin
On 25/06/2019 19:44, Jonathan Lemon wrote: On 20 Jun 2019, at 1:39, Kevin Laatz wrote: This patchset adds the ability to use unaligned chunks in the XDP umem. Currently, all chunk addresses passed to the umem are masked to be chunk size aligned (default is 2k, max is PAGE_SIZE). This limits

Re: [PATCH 00/11] XDP unaligned chunk placement support

2019-06-25 Thread Jonathan Lemon
On 20 Jun 2019, at 1:39, Kevin Laatz wrote: This patchset adds the ability to use unaligned chunks in the XDP umem. Currently, all chunk addresses passed to the umem are masked to be chunk size aligned (default is 2k, max is PAGE_SIZE). This limits where we can place chunks within the umem a

Re: [PATCH 00/11] XDP unaligned chunk placement support

2019-06-25 Thread Laatz, Kevin
On 24/06/2019 16:38, Björn Töpel wrote: On Thu, 20 Jun 2019 at 18:55, Kevin Laatz wrote: This patchset adds the ability to use unaligned chunks in the XDP umem. Currently, all chunk addresses passed to the umem are masked to be chunk size aligned (default is 2k, max is PAGE_SIZE). This limi

Re: [PATCH 00/11] XDP unaligned chunk placement support

2019-06-24 Thread Björn Töpel
On Thu, 20 Jun 2019 at 18:55, Kevin Laatz wrote: > > This patchset adds the ability to use unaligned chunks in the XDP umem. > > Currently, all chunk addresses passed to the umem are masked to be chunk > size aligned (default is 2k, max is PAGE_SIZE). This limits where we can > place chunks within

[PATCH 00/11] XDP unaligned chunk placement support

2019-06-20 Thread Kevin Laatz
This patchset adds the ability to use unaligned chunks in the XDP umem. Currently, all chunk addresses passed to the umem are masked to be chunk size aligned (default is 2k, max is PAGE_SIZE). This limits where we can place chunks within the umem as well as limiting the packet sizes that are suppo

[PATCH 00/11] XDP unaligned chunk placement support

2019-06-20 Thread Kevin Laatz
This patchset adds the ability to use unaligned chunks in the XDP umem. Currently, all chunk addresses passed to the umem are masked to be chunk size aligned (default is 2k, max is PAGE_SIZE). This limits where we can place chunks within the umem as well as limiting the packet sizes that are suppo