Re: [PATCH 00/10] Remove uninitialized_var() macro

2020-06-04 Thread Kees Cook
On Thu, Jun 04, 2020 at 09:26:58AM +0200, Sedat Dilek wrote: > On Thu, Jun 4, 2020 at 5:33 AM Nathan Chancellor > wrote: > > > > On Wed, Jun 03, 2020 at 04:31:53PM -0700, Kees Cook wrote: > > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > > > (or can in the future), and

Re: [PATCH 00/10] Remove uninitialized_var() macro

2020-06-04 Thread Sedat Dilek
On Thu, Jun 4, 2020 at 5:33 AM Nathan Chancellor wrote: > > On Wed, Jun 03, 2020 at 04:31:53PM -0700, Kees Cook wrote: > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > > (or can in the future), and suppresses unrelated compiler warnings > > (e.g. "unused variable"). If t

Re: [PATCH 00/10] Remove uninitialized_var() macro

2020-06-03 Thread Nathan Chancellor
On Wed, Jun 03, 2020 at 04:31:53PM -0700, Kees Cook wrote: > Using uninitialized_var() is dangerous as it papers over real bugs[1] > (or can in the future), and suppresses unrelated compiler warnings > (e.g. "unused variable"). If the compiler thinks it is uninitialized, > either simply initialize

Re: [PATCH 00/10] Remove uninitialized_var() macro

2020-06-03 Thread Sedat Dilek
On Thu, Jun 4, 2020 at 3:44 AM Kees Cook wrote: > > On Thu, Jun 04, 2020 at 03:23:28AM +0200, Sedat Dilek wrote: > > what is the base for your patchset? > > Hi! This was actually on Linus's latest tree (which is basically -next), > mostly because I figured this might be a bit of an RFC but if it w

Re: [PATCH 00/10] Remove uninitialized_var() macro

2020-06-03 Thread Kees Cook
On Thu, Jun 04, 2020 at 03:23:28AM +0200, Sedat Dilek wrote: > what is the base for your patchset? Hi! This was actually on Linus's latest tree (which is basically -next), mostly because I figured this might be a bit of an RFC but if it was clean enough, it might actually make the merge window (I

Re: [PATCH 00/10] Remove uninitialized_var() macro

2020-06-03 Thread Sedat Dilek
On Thu, Jun 4, 2020 at 1:32 AM Kees Cook wrote: > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > (or can in the future), and suppresses unrelated compiler warnings > (e.g. "unused variable"). If the compiler thinks it is uninitialized, > either simply initialize the vari

[PATCH 00/10] Remove uninitialized_var() macro

2020-06-03 Thread Kees Cook
Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the compiler thinks it is uninitialized, either simply initialize the variable or make compiler changes. As recommended[2] by[3] Lin