Re: [PATCH 0/8] Cleanup/fix the sk_alloc() call

2007-10-31 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 31, 2007 at 05:32:20PM +0300, Pavel Emelyanov escreveu: > Arnaldo Carvalho de Melo wrote: > > Em Wed, Oct 31, 2007 at 04:40:01PM +0300, Pavel Emelyanov escreveu: > >> The sk_alloc() function suffers from two problems: > >> 1 (major). The error path is not clean in it - if the security >

Re: [PATCH 0/8] Cleanup/fix the sk_alloc() call

2007-10-31 Thread Pavel Emelyanov
Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 31, 2007 at 04:40:01PM +0300, Pavel Emelyanov escreveu: >> The sk_alloc() function suffers from two problems: >> 1 (major). The error path is not clean in it - if the security >>call fails, the net namespace is not put, if the try_module_get >>f

Re: [PATCH 0/8] Cleanup/fix the sk_alloc() call

2007-10-31 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 31, 2007 at 04:40:01PM +0300, Pavel Emelyanov escreveu: > The sk_alloc() function suffers from two problems: > 1 (major). The error path is not clean in it - if the security >call fails, the net namespace is not put, if the try_module_get >fails additionally the security contex

[PATCH 0/8] Cleanup/fix the sk_alloc() call

2007-10-31 Thread Pavel Emelyanov
The sk_alloc() function suffers from two problems: 1 (major). The error path is not clean in it - if the security call fails, the net namespace is not put, if the try_module_get fails additionally the security context is not released; 2 (minor). The zero_it argument is misleading, as it does