Re: [PATCH 0/4 net-next] flow_offload: update mangle action representation

2019-09-02 Thread Pablo Neira Ayuso
On Sun, Sep 01, 2019 at 01:47:54PM -0700, Jakub Kicinski wrote: > On Sat, 31 Aug 2019 16:22:17 +0200, Pablo Neira Ayuso wrote: [...] > > > Please see the definitions of: > > > > > > struct nfp_fl_set_eth > > > struct nfp_fl_set_ip4_addrs > > > struct nfp_fl_set_ip4_ttl_tos > > > struct nfp_fl_set_

Re: [PATCH 0/4 net-next] flow_offload: update mangle action representation

2019-09-01 Thread Jakub Kicinski
On Sat, 31 Aug 2019 16:22:17 +0200, Pablo Neira Ayuso wrote: > On Fri, Aug 30, 2019 at 03:33:51PM -0700, Jakub Kicinski wrote: > > On Fri, 30 Aug 2019 11:07:10 +0200, Pablo Neira Ayuso wrote: > > > > > * The front-end coalesces consecutive pedit actions into one single > > > > > word, so driver

Re: [PATCH 0/4 net-next] flow_offload: update mangle action representation

2019-08-31 Thread Pablo Neira Ayuso
On Fri, Aug 30, 2019 at 03:33:51PM -0700, Jakub Kicinski wrote: > On Fri, 30 Aug 2019 11:07:10 +0200, Pablo Neira Ayuso wrote: > > > > * The front-end coalesces consecutive pedit actions into one single > > > > word, so drivers can mangle IPv6 and ethernet address fields in one > > > > single g

Re: [PATCH 0/4 net-next] flow_offload: update mangle action representation

2019-08-30 Thread Jakub Kicinski
On Fri, 30 Aug 2019 11:07:10 +0200, Pablo Neira Ayuso wrote: > > > * The front-end coalesces consecutive pedit actions into one single > > > word, so drivers can mangle IPv6 and ethernet address fields in one > > > single go. > > > > You still only coalesce up to 16 bytes, no? > > You onl

Re: [PATCH 0/4 net-next] flow_offload: update mangle action representation

2019-08-30 Thread Pablo Neira Ayuso
On Thu, Aug 29, 2019 at 06:54:48PM -0700, Jakub Kicinski wrote: > On Fri, 30 Aug 2019 02:53:32 +0200, Pablo Neira Ayuso wrote: > > * Offsets do not need to be on the 32-bits boundaries anymore. This > > patchset adds front-end code to adjust the offset and length coming > > from the tc pedit re

Re: [PATCH 0/4 net-next] flow_offload: update mangle action representation

2019-08-29 Thread Jakub Kicinski
On Fri, 30 Aug 2019 02:53:32 +0200, Pablo Neira Ayuso wrote: > * Offsets do not need to be on the 32-bits boundaries anymore. This > patchset adds front-end code to adjust the offset and length coming > from the tc pedit representation, so drivers get an exact header field > offset and length

[PATCH 0/4 net-next] flow_offload: update mangle action representation

2019-08-29 Thread Pablo Neira Ayuso
Hi, This patch updates the mangle action representation: Patch 1) Undo bitwise NOT operation on the mangle mask (coming from tc pedit userspace). Patch 2) mangle value &= mask from the front-end side. Patch 3) adjust offset, length and coalesce consecutive actions. Patch 4) add payloa