Re: [PATCH 0/4] net: phy: Register header file for Microsemi PHYs.

2016-09-08 Thread Raju Lakkaraju
Hi Andrew, Thank you for review the code and given valuable comments. Other driver is not yet complete. I accepted your review comment. I will keep all Register defined MACRO's in mscc.c file. Thanks, Raju. On Fri, Aug 26, 2016 at 03:40:28PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > >

Re: [PATCH 0/4] net: phy: Register header file for Microsemi PHYs.

2016-08-26 Thread Andrew Lunn
> I would like to share these register definitions share between > Microsemi multiple drivers. Hi Raju Please post a patch which does this, i.e. modifies multiple drivers to share the header file. However, just be aware, if it turns out these multiple drivers are very similar, we might actually

Re: [PATCH 0/4] net: phy: Register header file for Microsemi PHYs.

2016-08-26 Thread Raju Lakkaraju
Hi Florian, I would like to share these register definitions share between Microsemi multiple drivers. I refer the existing PHY drivers and follow the similar to "dp83640_reg.h" for register definitions. Thanks, Raju. On Wed, Aug 24, 2016 at 10:15:33AM -0700, Florian Fainelli wrote: > EXTERNAL

Re: [PATCH 0/4] net: phy: Register header file for Microsemi PHYs.

2016-08-24 Thread Florian Fainelli
On 08/24/2016 04:58 AM, Raju Lakkaraju wrote: > From: Nagaraju Lakkaraju > > This is Microsemi's VSC 85xx PHY register definitions header file. Please keep these register definitions local to the code using them unless they are shared between multiple drivers. -- Florian

Re: [PATCH 0/4] net: phy: Register header file for Microsemi PHYs.

2016-08-24 Thread Nagaraju Lakkaraju
Hi Andrew, Thank you for quick response. I did not use "git send-email" I created 5 patches and sent them by using 5 individual mails thru Mutt. Thanks, Raju. On Wed, Aug 24, 2016 at 02:45:26PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > On Wed, Aug 24, 2016 at 11:58:01AM +, Raju Lakka

Re: [PATCH 0/4] net: phy: Register header file for Microsemi PHYs.

2016-08-24 Thread Andrew Lunn
On Wed, Aug 24, 2016 at 11:58:01AM +, Raju Lakkaraju wrote: > From: Nagaraju Lakkaraju > > This is Microsemi's VSC 85xx PHY register definitions header file. Hi Raju No other phy driver has its registers separated from the code. So lets see what Florian says about this. However, if you are

Re: [PATCH 0/4] net: phy: Register header file for Microsemi PHYs.

2016-08-24 Thread Andrew Lunn
On Wed, Aug 24, 2016 at 11:58:01AM +, Raju Lakkaraju wrote: > From: Nagaraju Lakkaraju > > This is Microsemi's VSC 85xx PHY register definitions header file. Hi Raju Patch [0/X] is the cover note. It should contain an overview of the patch series and why this patch series is needed. It shou

[PATCH 0/4] net: phy: Register header file for Microsemi PHYs.

2016-08-24 Thread Raju Lakkaraju
From: Nagaraju Lakkaraju This is Microsemi's VSC 85xx PHY register definitions header file. Signed-off-by: Nagaraju Lakkaraju --- drivers/net/phy/mscc_reg.h | 135 + 1 file changed, 135 insertions(+) create mode 100644 drivers/net/phy/mscc_reg.h di