Re: [PATCH 0/4] atl1: Revised Attansic L1 ethernet driver

2006-11-25 Thread Jay Cliburn
Luca Tettamanti wrote: Got the board, done some basic testing: so far so good :) The controller also supports MSI and (at least with my chipset - G965) it works fine: 218: 80649 0 PCI-MSI-edge eth1 which is nice, otherwise it ends up sharing the IRQ with SATA and USB. I

Re: [PATCH 0/4] atl1: Revised Attansic L1 ethernet driver

2006-11-25 Thread Luca Tettamanti
Hello, Luca Tettamanti <[EMAIL PROTECTED]> ha scritto: > Chris Snook <[EMAIL PROTECTED]> ha scritto: >> >> I've been working on this with Jay since his initial submission. Thanks >> to everyone who has provided feedback on the resubmit. We're currently >> quite short on actual testers, since

Re: [PATCH 0/4] atl1: Revised Attansic L1 ethernet driver

2006-11-19 Thread Alan
Would be nice if it used atl_ not at_ so its less likely to cause namespace clashes. You have various macros for swaps that are pretty ugly - we have cpu_to and le/be_to_cpu functions for most swapping cases and these are generally optimised assembler (eg bswap on x86) AT_DESC_USED/UNUSED would b

[PATCH 0/4] atl1: Revised Attansic L1 ethernet driver

2006-11-19 Thread Jay Cliburn
Based upon feedback from Stephen Hemminger and Francois Romieu, please consider this resubmitted patchset that provides support for the Attansic L1 gigabit ethernet adapter. This patchset is built against 2.6.19-rc6. The original patchset was submitted 20060927. The monolithic version of this