Re: [PATCH 0/3] cxgb3 driver update

2007-08-23 Thread Divy Le Ray
Hi Al, Speaking of cxgb3, could you explain what the hell is static int do_term(struct t3cdev *dev, struct sk_buff *skb) { unsigned int hwtid = ntohl(skb->priority) >> 8 & 0xf; doing? AFAIK, skb->priority is not net-endian... the RDMA connection id is saved in the skb's priority

Re: [PATCH 0/3] cxgb3 driver update

2007-08-23 Thread Al Viro
On Wed, Aug 22, 2007 at 11:35:20PM -0700, Divy Le Ray wrote: > Hi Jeff, > > I'm submitting three more patches for inclusion in netdev#upstream. > These patches are built over the series I resent yesterday night. > The patch numbering reflects the stacking. > > Here is a brief description: > - a

[PATCH 0/3] cxgb3 driver update

2007-08-22 Thread Divy Le Ray
Hi Jeff, I'm submitting three more patches for inclusion in netdev#upstream. These patches are built over the series I resent yesterday night. The patch numbering reflects the stacking. Here is a brief description: - avoid false positives in the xgmac hang workaround - Properly set the CQ_ER