Re: [PATCH 0/3] Check gso_size of packets when forwarding

2018-01-22 Thread Pravin Shelar
On Mon, Jan 22, 2018 at 12:14 PM, David Miller wrote: > From: Pravin Shelar > Date: Fri, 19 Jan 2018 13:54:15 -0800 > >> I agree it is not perfect. But the other proposed patch does not fix >> the connectivity issue. It only adds log msg in such cases at cost >> of extra checks/code. Therefore I

Re: [PATCH 0/3] Check gso_size of packets when forwarding

2018-01-22 Thread Stephen Hemminger
On Mon, 22 Jan 2018 15:14:53 -0500 (EST) David Miller wrote: > From: Pravin Shelar > Date: Fri, 19 Jan 2018 13:54:15 -0800 > > > I agree it is not perfect. But the other proposed patch does not fix > > the connectivity issue. It only adds log msg in such cases at cost > > of extra checks/code.

Re: [PATCH 0/3] Check gso_size of packets when forwarding

2018-01-22 Thread David Miller
From: Pravin Shelar Date: Fri, 19 Jan 2018 13:54:15 -0800 > I agree it is not perfect. But the other proposed patch does not fix > the connectivity issue. It only adds log msg in such cases at cost > of extra checks/code. Therefore I prefer the easier fix for the > issue which also fixes for all

Re: [PATCH 0/3] Check gso_size of packets when forwarding

2018-01-19 Thread Pravin Shelar
On Fri, Jan 19, 2018 at 3:58 AM, Daniel Axtens wrote: > Pravin Shelar writes: > >> On Thu, Jan 18, 2018 at 5:28 PM, Daniel Axtens wrote: >>> Pravin Shelar writes: >>> On Thu, Jan 18, 2018 at 5:08 AM, Daniel Axtens wrote: > Pravin Shelar writes: > >> On Mon, Jan 15, 2018 at 6:

Re: [PATCH 0/3] Check gso_size of packets when forwarding

2018-01-19 Thread Daniel Axtens
Pravin Shelar writes: > On Thu, Jan 18, 2018 at 5:28 PM, Daniel Axtens wrote: >> Pravin Shelar writes: >> >>> On Thu, Jan 18, 2018 at 5:08 AM, Daniel Axtens wrote: Pravin Shelar writes: > On Mon, Jan 15, 2018 at 6:09 PM, Daniel Axtens wrote: >> When regular packets are forw

Re: [PATCH 0/3] Check gso_size of packets when forwarding

2018-01-18 Thread Pravin Shelar
On Thu, Jan 18, 2018 at 5:28 PM, Daniel Axtens wrote: > Pravin Shelar writes: > >> On Thu, Jan 18, 2018 at 5:08 AM, Daniel Axtens wrote: >>> Pravin Shelar writes: >>> On Mon, Jan 15, 2018 at 6:09 PM, Daniel Axtens wrote: > When regular packets are forwarded, we validate their size aga

Re: [PATCH 0/3] Check gso_size of packets when forwarding

2018-01-18 Thread Daniel Axtens
Daniel Axtens writes: > Pravin Shelar writes: > >> On Thu, Jan 18, 2018 at 5:08 AM, Daniel Axtens wrote: >>> Pravin Shelar writes: >>> On Mon, Jan 15, 2018 at 6:09 PM, Daniel Axtens wrote: > When regular packets are forwarded, we validate their size against the > MTU of the desti

Re: [PATCH 0/3] Check gso_size of packets when forwarding

2018-01-18 Thread Daniel Axtens
Pravin Shelar writes: > On Thu, Jan 18, 2018 at 5:08 AM, Daniel Axtens wrote: >> Pravin Shelar writes: >> >>> On Mon, Jan 15, 2018 at 6:09 PM, Daniel Axtens wrote: When regular packets are forwarded, we validate their size against the MTU of the destination device. However, when GSO

Re: [PATCH 0/3] Check gso_size of packets when forwarding

2018-01-18 Thread Pravin Shelar
On Thu, Jan 18, 2018 at 5:08 AM, Daniel Axtens wrote: > Pravin Shelar writes: > >> On Mon, Jan 15, 2018 at 6:09 PM, Daniel Axtens wrote: >>> When regular packets are forwarded, we validate their size against the >>> MTU of the destination device. However, when GSO packets are >>> forwarded, we d

Re: [PATCH 0/3] Check gso_size of packets when forwarding

2018-01-18 Thread Daniel Axtens
Daniel Axtens writes: > Jason Wang writes: > >> On 2018年01月18日 16:28, Pravin Shelar wrote: >>> On Mon, Jan 15, 2018 at 6:09 PM, Daniel Axtens wrote: When regular packets are forwarded, we validate their size against the MTU of the destination device. However, when GSO packets are

Re: [PATCH 0/3] Check gso_size of packets when forwarding

2018-01-18 Thread Daniel Axtens
Jason Wang writes: > On 2018年01月18日 16:28, Pravin Shelar wrote: >> On Mon, Jan 15, 2018 at 6:09 PM, Daniel Axtens wrote: >>> When regular packets are forwarded, we validate their size against the >>> MTU of the destination device. However, when GSO packets are >>> forwarded, we do not validate t

Re: [PATCH 0/3] Check gso_size of packets when forwarding

2018-01-18 Thread Daniel Axtens
Pravin Shelar writes: > On Mon, Jan 15, 2018 at 6:09 PM, Daniel Axtens wrote: >> When regular packets are forwarded, we validate their size against the >> MTU of the destination device. However, when GSO packets are >> forwarded, we do not validate their size against the MTU. We >> implicitly as

Re: [PATCH 0/3] Check gso_size of packets when forwarding

2018-01-18 Thread Jason Wang
On 2018年01月18日 16:28, Pravin Shelar wrote: On Mon, Jan 15, 2018 at 6:09 PM, Daniel Axtens wrote: When regular packets are forwarded, we validate their size against the MTU of the destination device. However, when GSO packets are forwarded, we do not validate their size against the MTU. We imp

Re: [PATCH 0/3] Check gso_size of packets when forwarding

2018-01-18 Thread Pravin Shelar
On Mon, Jan 15, 2018 at 6:09 PM, Daniel Axtens wrote: > When regular packets are forwarded, we validate their size against the > MTU of the destination device. However, when GSO packets are > forwarded, we do not validate their size against the MTU. We > implicitly assume that when they are segmen

Re: [PATCH 0/3] Check gso_size of packets when forwarding

2018-01-17 Thread David Miller
From: Daniel Axtens Date: Tue, 16 Jan 2018 13:09:17 +1100 > When regular packets are forwarded, we validate their size against the > MTU of the destination device. However, when GSO packets are > forwarded, we do not validate their size against the MTU. We > implicitly assume that when they are s

[PATCH 0/3] Check gso_size of packets when forwarding

2018-01-15 Thread Daniel Axtens
When regular packets are forwarded, we validate their size against the MTU of the destination device. However, when GSO packets are forwarded, we do not validate their size against the MTU. We implicitly assume that when they are segmented, the resultant packets will be correctly sized. This is no