Re: [PATCH 0/2] tools: bpftool: add net (un)load command to load XDP

2019-07-31 Thread David Ahern
On 7/30/19 7:21 PM, Jakub Kicinski wrote: > If bpftool was taught to do equivalent of 'ip link' that would be very different story and I would be opposed to that. >>> Yes, that'd be pretty clear cut, only the XDP stuff is a bit more >>> of a judgement call. >> bpftool must be able t

Re: [PATCH 0/2] tools: bpftool: add net (un)load command to load XDP

2019-07-31 Thread Jesper Dangaard Brouer
On Tue, 30 Jul 2019 18:52:40 -0700 Alexei Starovoitov wrote: > On Tue, Jul 30, 2019 at 06:21:44PM -0700, Jakub Kicinski wrote: > > > > Duplicating the same features in bpftool will only diminish the > > > > incentive for moving iproute2 to libbpf. > > > > > > not at all. why do you think so

Re: [PATCH 0/2] tools: bpftool: add net (un)load command to load XDP

2019-07-30 Thread Alexei Starovoitov
On Tue, Jul 30, 2019 at 06:21:44PM -0700, Jakub Kicinski wrote: > > > Duplicating the same features in bpftool will only diminish the > > > incentive for moving iproute2 to libbpf. > > > > not at all. why do you think so? > > Because iproute2's BPF has fallen behind so the simplest thing is to

Re: [PATCH 0/2] tools: bpftool: add net (un)load command to load XDP

2019-07-30 Thread Jakub Kicinski
On Tue, 30 Jul 2019 17:23:39 -0700, Alexei Starovoitov wrote: > On Tue, Jul 30, 2019 at 05:07:25PM -0700, Jakub Kicinski wrote: > > Nothing meaning you disagree it's duplicated effort and unnecessary > > LoC the community has to maintain, review, test..? > > I don't see duplicated effort. Coul

Re: [PATCH 0/2] tools: bpftool: add net (un)load command to load XDP

2019-07-30 Thread Alexei Starovoitov
On Tue, Jul 30, 2019 at 05:07:25PM -0700, Jakub Kicinski wrote: > On Tue, 30 Jul 2019 16:17:56 -0700, Alexei Starovoitov wrote: > > On Tue, Jul 30, 2019 at 03:59:15PM -0700, Jakub Kicinski wrote: > > > On Wed, 31 Jul 2019 03:48:19 +0900, Daniel T. Lee wrote: > > > > Currently, bpftool net only su

Re: [PATCH 0/2] tools: bpftool: add net (un)load command to load XDP

2019-07-30 Thread Jakub Kicinski
On Tue, 30 Jul 2019 16:17:56 -0700, Alexei Starovoitov wrote: > On Tue, Jul 30, 2019 at 03:59:15PM -0700, Jakub Kicinski wrote: > > On Wed, 31 Jul 2019 03:48:19 +0900, Daniel T. Lee wrote: > > > Currently, bpftool net only supports dumping progs loaded on the > > > interface. To load XDP prog on

Re: [PATCH 0/2] tools: bpftool: add net (un)load command to load XDP

2019-07-30 Thread Alexei Starovoitov
On Tue, Jul 30, 2019 at 03:59:15PM -0700, Jakub Kicinski wrote: > On Wed, 31 Jul 2019 03:48:19 +0900, Daniel T. Lee wrote: > > Currently, bpftool net only supports dumping progs loaded on the > > interface. To load XDP prog on interface, user must use other tool > > (eg. iproute2). By this patch, w

Re: [PATCH 0/2] tools: bpftool: add net (un)load command to load XDP

2019-07-30 Thread Jakub Kicinski
On Wed, 31 Jul 2019 03:48:19 +0900, Daniel T. Lee wrote: > Currently, bpftool net only supports dumping progs loaded on the > interface. To load XDP prog on interface, user must use other tool > (eg. iproute2). By this patch, with `bpftool net (un)load`, user can > (un)load XDP prog on interface.

Re: [PATCH 0/2] tools: bpftool: add net (un)load command to load XDP

2019-07-30 Thread Andrii Nakryiko
On Tue, Jul 30, 2019 at 11:48 AM Daniel T. Lee wrote: > > Currently, bpftool net only supports dumping progs loaded on the > interface. To load XDP prog on interface, user must use other tool > (eg. iproute2). By this patch, with `bpftool net (un)load`, user can > (un)load XDP prog on interface. >

[PATCH 0/2] tools: bpftool: add net (un)load command to load XDP

2019-07-30 Thread Daniel T. Lee
Currently, bpftool net only supports dumping progs loaded on the interface. To load XDP prog on interface, user must use other tool (eg. iproute2). By this patch, with `bpftool net (un)load`, user can (un)load XDP prog on interface. $ ./bpftool prog ... 208: xdp name xdp_prog1 tag ad