Re: [PATCH 0/2] netem: trace enhancement: kernel

2007-12-28 Thread Ariane Keller
Thanks for your comments! Patrick McHardy wrote: Ariane Keller wrote: +/* must be divisible by 4 (=#pkts)*/ +#define DATA_PACKAGE 4000 Its not obvious that this refers to a size, please rename to something more approriate. And why is it hardcoded to 4000? Shouldn't it be related to NLMSG_GO

Re: [PATCH 0/2] netem: trace enhancement: kernel

2007-12-28 Thread Patrick McHardy
Ariane Keller wrote: +struct tc_netem_stats +{ +int packetcount; +int packetok; +int normaldelay; +int drops; +int dupl; +int corrupt; +int novaliddata; +int reloadbuffer; These should be unsigned int or __u32. diff -uprN -X linux-2.6.23.8/Documentation/dontdi

Re: [PATCH 0/2] netem: trace enhancement: kernel

2007-12-23 Thread Ariane Keller
This patch applies to kernel 2.6.23. It enhances the network emulator netem with the possibility to read all delay/drop/duplicate etc values from a trace file. This trace file contains for each packet to be processed one value. The values are read from the file in a user space process called flows