Re: [PATCH 0/2] net/sched: Add hardware specific counters to TC actions

2018-09-21 Thread Eelco Chaudron
On 20 Sep 2018, at 16:14, Jakub Kicinski wrote: > On Thu, 20 Sep 2018 09:14:08 +0200, Eelco Chaudron wrote: >> Is there anything else blocking from getting this into net-next? >> >> I still think this patch is beneficial for the full user experience, and >> I’ve got requests from QA and others

Re: [PATCH 0/2] net/sched: Add hardware specific counters to TC actions

2018-09-20 Thread Jakub Kicinski
On Thu, 20 Sep 2018 09:14:08 +0200, Eelco Chaudron wrote: > Is there anything else blocking from getting this into net-next? > > I still think this patch is beneficial for the full user experience, and > I’ve got requests from QA and others for this. Not from my perspective, the numbers look oka

Re: [PATCH 0/2] net/sched: Add hardware specific counters to TC actions

2018-09-20 Thread Eelco Chaudron
On 29 Aug 2018, at 20:12, Jakub Kicinski wrote: On Wed, 29 Aug 2018 11:43:47 +0200, Eelco Chaudron wrote: On 23 Aug 2018, at 20:14, Jakub Kicinski wrote: On Mon, 20 Aug 2018 16:03:40 +0200, Eelco Chaudron wrote: On 17 Aug 2018, at 13:27, Jakub Kicinski wrote: On Thu, 16 Aug 2018 14:02:44

Re: [PATCH 0/2] net/sched: Add hardware specific counters to TC actions

2018-08-29 Thread Jakub Kicinski
On Wed, 29 Aug 2018 11:43:47 +0200, Eelco Chaudron wrote: > On 23 Aug 2018, at 20:14, Jakub Kicinski wrote: > > > On Mon, 20 Aug 2018 16:03:40 +0200, Eelco Chaudron wrote: > >> On 17 Aug 2018, at 13:27, Jakub Kicinski wrote: > >>> On Thu, 16 Aug 2018 14:02:44 +0200, Eelco Chaudron wrote: > >

Re: [PATCH 0/2] net/sched: Add hardware specific counters to TC actions

2018-08-29 Thread Jakub Kicinski
On Wed, 29 Aug 2018 12:23:15 +0200, Paolo Abeni wrote: > On Thu, 2018-08-23 at 20:14 +0200, Jakub Kicinski wrote: > > I asked Louis to run some tests while I'm travelling, and he reports > > that my worry about reporting the extra stats was unfounded. Update > > function does not show up in traces

Re: [PATCH 0/2] net/sched: Add hardware specific counters to TC actions

2018-08-29 Thread Paolo Abeni
On Thu, 2018-08-23 at 20:14 +0200, Jakub Kicinski wrote: > I asked Louis to run some tests while I'm travelling, and he reports > that my worry about reporting the extra stats was unfounded. Update > function does not show up in traces at all. It seems under stress > (generated with stress-ng) th

Re: [PATCH 0/2] net/sched: Add hardware specific counters to TC actions

2018-08-29 Thread Eelco Chaudron
On 23 Aug 2018, at 20:14, Jakub Kicinski wrote: On Mon, 20 Aug 2018 16:03:40 +0200, Eelco Chaudron wrote: On 17 Aug 2018, at 13:27, Jakub Kicinski wrote: On Thu, 16 Aug 2018 14:02:44 +0200, Eelco Chaudron wrote: On 11 Aug 2018, at 21:06, David Miller wrote: From: Jakub Kicinski Date: Th

Re: [PATCH 0/2] net/sched: Add hardware specific counters to TC actions

2018-08-23 Thread Jakub Kicinski
On Mon, 20 Aug 2018 16:03:40 +0200, Eelco Chaudron wrote: > On 17 Aug 2018, at 13:27, Jakub Kicinski wrote: > > On Thu, 16 Aug 2018 14:02:44 +0200, Eelco Chaudron wrote: > >> On 11 Aug 2018, at 21:06, David Miller wrote: > >> > >>> From: Jakub Kicinski > >>> Date: Thu, 9 Aug 2018 20:26:08 -070

Re: [PATCH 0/2] net/sched: Add hardware specific counters to TC actions

2018-08-20 Thread Eelco Chaudron
On 17 Aug 2018, at 13:27, Jakub Kicinski wrote: On Thu, 16 Aug 2018 14:02:44 +0200, Eelco Chaudron wrote: On 11 Aug 2018, at 21:06, David Miller wrote: From: Jakub Kicinski Date: Thu, 9 Aug 2018 20:26:08 -0700 It is not immediately clear why this is needed. The memory and updating two

Re: [PATCH 0/2] net/sched: Add hardware specific counters to TC actions

2018-08-17 Thread Jakub Kicinski
On Thu, 16 Aug 2018 14:02:44 +0200, Eelco Chaudron wrote: > On 11 Aug 2018, at 21:06, David Miller wrote: > > > From: Jakub Kicinski > > Date: Thu, 9 Aug 2018 20:26:08 -0700 > > > >> It is not immediately clear why this is needed. The memory and > >> updating two sets of counters won't come fo

Re: [PATCH 0/2] net/sched: Add hardware specific counters to TC actions

2018-08-16 Thread Eelco Chaudron
On 11 Aug 2018, at 21:06, David Miller wrote: From: Jakub Kicinski Date: Thu, 9 Aug 2018 20:26:08 -0700 It is not immediately clear why this is needed. The memory and updating two sets of counters won't come for free, so perhaps a stronger justification than troubleshooting is due? :S Netde

Re: [PATCH 0/2] net/sched: Add hardware specific counters to TC actions

2018-08-11 Thread David Miller
From: Jakub Kicinski Date: Thu, 9 Aug 2018 20:26:08 -0700 > It is not immediately clear why this is needed. The memory and > updating two sets of counters won't come for free, so perhaps a > stronger justification than troubleshooting is due? :S > > Netdev has counters for fallback vs forwarded

Re: [PATCH 0/2] net/sched: Add hardware specific counters to TC actions

2018-08-09 Thread Jakub Kicinski
On Thu, 9 Aug 2018 11:01:18 -0400, Eelco Chaudron wrote: > Add hardware specific counters to TC actions which will be exported > through the netlink API. This makes troubleshooting TC flower offload > easier, as it possible to differentiate the packets being offloaded. It is not immediately clear

[PATCH 0/2] net/sched: Add hardware specific counters to TC actions

2018-08-09 Thread Eelco Chaudron
Add hardware specific counters to TC actions which will be exported through the netlink API. This makes troubleshooting TC flower offload easier, as it possible to differentiate the packets being offloaded. Signed-off-by: Eelco Chaudron Eelco Chaudron (2): net/core: Add new basic hardware