Re: [PATCH 1/5] net: fec: properly support external PTP PHY for hardware time stamping

2020-07-08 Thread Richard Cochran
On Tue, Jul 07, 2020 at 10:04:37AM +0300, Vladimir Oltean wrote: > > > We do it like this: > > > - DSA: If there is a timestamping switch stacked on top of a > > > timestamping Ethernet MAC, the switch hijacks the .ndo_do_ioctl of the > > > host port, and you are supposed to use the PTP clock o

Re: [PATCH 1/5] net: fec: properly support external PTP PHY for hardware time stamping

2020-07-08 Thread Richard Cochran
On Mon, Jul 06, 2020 at 09:33:30PM +0300, Sergey Organov wrote: > Vladimir Oltean writes: > > > On Mon, Jul 06, 2020 at 06:21:59PM +0300, Sergey Organov wrote: > > Both are finicky in their own ways. There is no real way for the user to > > select which PHC they want to use. The assumption is tha

Re: [PATCH 1/5] net: fec: properly support external PTP PHY for hardware time stamping

2020-07-07 Thread Sergey Organov
Vladimir Oltean writes: > On Mon, Jul 06, 2020 at 09:33:30PM +0300, Sergey Organov wrote: [...] > >> I'll then make these 2 changes separate in v2 indeed, though I'm not >> aware about Fixes: tag and if I should do something about it. Any clues? >> > > Add these 2 lines to your .gitconfig file

Re: [PATCH 1/5] net: fec: properly support external PTP PHY for hardware time stamping

2020-07-07 Thread Vladimir Oltean
On Mon, Jul 06, 2020 at 09:33:30PM +0300, Sergey Organov wrote: > Vladimir Oltean writes: > > > On Mon, Jul 06, 2020 at 06:21:59PM +0300, Sergey Organov wrote: > >> Vladimir Oltean writes: > > >> > Hi Sergey, > >> > > >> > On Mon, Jul 06, 2020 at 05:26:12PM +0300, Sergey Organov wrote: > >> >>

Re: [PATCH 1/5] net: fec: properly support external PTP PHY for hardware time stamping

2020-07-06 Thread Sergey Organov
Vladimir Oltean writes: > On Mon, Jul 06, 2020 at 06:21:59PM +0300, Sergey Organov wrote: >> Vladimir Oltean writes: >> > Hi Sergey, >> > >> > On Mon, Jul 06, 2020 at 05:26:12PM +0300, Sergey Organov wrote: >> >> When external PTP-aware PHY is in use, it's that PHY that is to time >> >> stamp

Re: [PATCH 1/5] net: fec: properly support external PTP PHY for hardware time stamping

2020-07-06 Thread Vladimir Oltean
On Mon, Jul 06, 2020 at 06:21:59PM +0300, Sergey Organov wrote: > Vladimir Oltean writes: > > > Hi Sergey, > > > > On Mon, Jul 06, 2020 at 05:26:12PM +0300, Sergey Organov wrote: > >> When external PTP-aware PHY is in use, it's that PHY that is to time > >> stamp network packets, and it's that PH

Re: [PATCH 1/5] net: fec: properly support external PTP PHY for hardware time stamping

2020-07-06 Thread Sergey Organov
Vladimir Oltean writes: > Hi Sergey, > > On Mon, Jul 06, 2020 at 05:26:12PM +0300, Sergey Organov wrote: >> When external PTP-aware PHY is in use, it's that PHY that is to time >> stamp network packets, and it's that PHY where configuration requests >> of time stamping features are to be routed.

Re: [PATCH 1/5] net: fec: properly support external PTP PHY for hardware time stamping

2020-07-06 Thread Vladimir Oltean
Hi Sergey, On Mon, Jul 06, 2020 at 05:26:12PM +0300, Sergey Organov wrote: > When external PTP-aware PHY is in use, it's that PHY that is to time > stamp network packets, and it's that PHY where configuration requests > of time stamping features are to be routed. > > To achieve these goals: > >

[PATCH 1/5] net: fec: properly support external PTP PHY for hardware time stamping

2020-07-06 Thread Sergey Organov
When external PTP-aware PHY is in use, it's that PHY that is to time stamp network packets, and it's that PHY where configuration requests of time stamping features are to be routed. To achieve these goals: 1. Make sure we don't time stamp packets when external PTP PHY is in use 2. Make sure we