Re: [PATCH -next] pps: using ERR_PTR instead of NULL while pps_register_source fails

On Tue, Nov 27, 2018 at 09:36:38AM +0100, Rodolfo Giometti wrote: > On 27/11/2018 08:34, Greg KH wrote: > > On Mon, Nov 26, 2018 at 11:43:06AM +0100, Rodolfo Giometti wrote: > > > On 26/11/2018 11:24, YueHaibing wrote: > > > > pps_register_source() has keeps error codes in a local variable, > > > >

Re: [PATCH -next] pps: using ERR_PTR instead of NULL while pps_register_source fails

On 27/11/2018 08:34, Greg KH wrote: On Mon, Nov 26, 2018 at 11:43:06AM +0100, Rodolfo Giometti wrote: On 26/11/2018 11:24, YueHaibing wrote: pps_register_source() has keeps error codes in a local variable, but it does not make use of the code. This patch let it return the errcode in case of fai

Re: [PATCH -next] pps: using ERR_PTR instead of NULL while pps_register_source fails

On Mon, Nov 26, 2018 at 11:43:06AM +0100, Rodolfo Giometti wrote: > On 26/11/2018 11:24, YueHaibing wrote: > > pps_register_source() has keeps error codes in a local variable, > > but it does not make use of the code. This patch let it return > > the errcode in case of failure. > > > > Suggested-b

Re: [PATCH -next] pps: using ERR_PTR instead of NULL while pps_register_source fails

On 26/11/2018 11:24, YueHaibing wrote: pps_register_source() has keeps error codes in a local variable, but it does not make use of the code. This patch let it return the errcode in case of failure. Suggested-by: Richard Cochran Signed-off-by: YueHaibing Acked-by: Rodolfo Giometti

[PATCH -next] pps: using ERR_PTR instead of NULL while pps_register_source fails

pps_register_source() has keeps error codes in a local variable, but it does not make use of the code. This patch let it return the errcode in case of failure. Suggested-by: Richard Cochran Signed-off-by: YueHaibing --- drivers/pps/clients/pps-gpio.c| 4 ++-- drivers/pps/clients/pps-ktimer.