Both of you are right.
I neglected, and this patch is wrong.
Thanks.
On 2020/5/6 23:15, Joe Perches wrote:
On Wed, 2020-05-06 at 16:51 +0300, Luciano Coelho wrote:
On Tue, 2020-05-05 at 20:19 -0700, Joe Perches wrote:
On Wed, 2020-05-06 at 11:07 +0800, Samuel Zou wrote:
This silences the fol
On Wed, 2020-05-06 at 16:51 +0300, Luciano Coelho wrote:
> On Tue, 2020-05-05 at 20:19 -0700, Joe Perches wrote:
> > On Wed, 2020-05-06 at 11:07 +0800, Samuel Zou wrote:
> > > This silences the following coccinelle warning:
> > >
> > > "WARNING: sum of probable bitmasks, consider |"
> >
> > I sug
On Tue, 2020-05-05 at 20:19 -0700, Joe Perches wrote:
> On Wed, 2020-05-06 at 11:07 +0800, Samuel Zou wrote:
> > This silences the following coccinelle warning:
> >
> > "WARNING: sum of probable bitmasks, consider |"
>
> I suggest instead ignoring bad and irrelevant warnings.
>
> PREFIX_LEN is 3
On Wed, 2020-05-06 at 11:07 +0800, Samuel Zou wrote:
> This silences the following coccinelle warning:
>
> "WARNING: sum of probable bitmasks, consider |"
I suggest instead ignoring bad and irrelevant warnings.
PREFIX_LEN is 32 not 0x20 or BIT(5)
PCI_DUMP_SIZE is 352
> diff --git a/drivers/net/
This silences the following coccinelle warning:
"WARNING: sum of probable bitmasks, consider |"
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/i
