Re: [PATCH -next] bpf: Use PTR_ERR_OR_ZERO in xsk_map_inc()

2019-08-20 Thread Daniel Borkmann
On 8/20/19 3:36 AM, YueHaibing wrote: Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Signed-off-by: YueHaibing Applied, thanks!

Re: [PATCH -next] bpf: Use PTR_ERR_OR_ZERO in xsk_map_inc()

2019-08-20 Thread Yuehaibing
On 2019/8/20 17:44, Dan Carpenter wrote: > On Tue, Aug 20, 2019 at 11:25:29AM +0200, Björn Töpel wrote: >> On Tue, 20 Aug 2019 at 10:59, Dan Carpenter wrote: >>> >>> On Tue, Aug 20, 2019 at 09:28:26AM +0200, Björn Töpel wrote: For future patches: Prefix AF_XDP socket work with "xsk:" and use

Re: [PATCH -next] bpf: Use PTR_ERR_OR_ZERO in xsk_map_inc()

2019-08-20 Thread Dan Carpenter
On Tue, Aug 20, 2019 at 11:25:29AM +0200, Björn Töpel wrote: > On Tue, 20 Aug 2019 at 10:59, Dan Carpenter wrote: > > > > On Tue, Aug 20, 2019 at 09:28:26AM +0200, Björn Töpel wrote: > > > For future patches: Prefix AF_XDP socket work with "xsk:" and use "PATCH > > > bpf-next" to let the developer

Re: [PATCH -next] bpf: Use PTR_ERR_OR_ZERO in xsk_map_inc()

2019-08-20 Thread Björn Töpel
On Tue, 20 Aug 2019 at 10:59, Dan Carpenter wrote: > > On Tue, Aug 20, 2019 at 09:28:26AM +0200, Björn Töpel wrote: > > For future patches: Prefix AF_XDP socket work with "xsk:" and use "PATCH > > bpf-next" to let the developers know what tree you're aiming for. > > There are over 300 trees in lin

Re: [PATCH -next] bpf: Use PTR_ERR_OR_ZERO in xsk_map_inc()

2019-08-20 Thread Dan Carpenter
On Tue, Aug 20, 2019 at 09:28:26AM +0200, Björn Töpel wrote: > For future patches: Prefix AF_XDP socket work with "xsk:" and use "PATCH > bpf-next" to let the developers know what tree you're aiming for. There are over 300 trees in linux-next. It impossible to try remember everyone's trees. No o

Re: [PATCH -next] bpf: Use PTR_ERR_OR_ZERO in xsk_map_inc()

2019-08-20 Thread Björn Töpel
On 2019-08-20 03:36, YueHaibing wrote: Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Signed-off-by: YueHaibing --- kernel/bpf/xskmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/bpf/xskmap.c b/kernel/bpf/xskmap.c index 4cc28e226398..942c662e2eed 10

[PATCH -next] bpf: Use PTR_ERR_OR_ZERO in xsk_map_inc()

2019-08-19 Thread YueHaibing
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Signed-off-by: YueHaibing --- kernel/bpf/xskmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/bpf/xskmap.c b/kernel/bpf/xskmap.c index 4cc28e226398..942c662e2eed 100644 --- a/kernel/bpf/xskmap.c +++ b/kernel