Re: [PATCH -next] Revert "ipv4: use skb coalescing in defragmentation"

2015-07-11 Thread David Miller
From: Florian Westphal Date: Sat, 11 Jul 2015 01:37:36 +0200 > This reverts commit 3cc4949269e01f39443d0fcfffb5bc6b47878d45. > > There is nothing wrong with coalescing during defragmentation, it > reduces truesize overhead and simplifies things for the receiving > socket (no fraglist walk needed

Re: [PATCH -next] Revert "ipv4: use skb coalescing in defragmentation"

2015-07-10 Thread Eric Dumazet
On Sat, 2015-07-11 at 01:37 +0200, Florian Westphal wrote: > This reverts commit 3cc4949269e01f39443d0fcfffb5bc6b47878d45. > > There is nothing wrong with coalescing during defragmentation, it > reduces truesize overhead and simplifies things for the receiving > socket (no fraglist walk needed). >

[PATCH -next] Revert "ipv4: use skb coalescing in defragmentation"

2015-07-10 Thread Florian Westphal
This reverts commit 3cc4949269e01f39443d0fcfffb5bc6b47878d45. There is nothing wrong with coalescing during defragmentation, it reduces truesize overhead and simplifies things for the receiving socket (no fraglist walk needed). However, it also destroys geometry of the original fragments. While t