Re: [PATCH - regression 4.1-rc8] can: fix loss of CAN frames in raw_rcv

2015-06-22 Thread Oliver Hartkopp
On 22.06.2015 13:49, Manfred Schlaegl wrote: On 2015-06-22 12:34, Oliver Hartkopp wrote: On 22.06.2015 12:10, Manfred Schlaegl wrote: Hypothetical example: If timestamping is enabled by the user and there is a significant delay between allocation and delivery of a skb (early allocation in dri

Re: [PATCH - regression 4.1-rc8] can: fix loss of CAN frames in raw_rcv

2015-06-22 Thread Manfred Schlaegl
Hello Oliver, On 2015-06-22 12:34, Oliver Hartkopp wrote: > Hello Manfred, > > On 22.06.2015 12:10, Manfred Schlaegl wrote: >> On 2015-06-21 18:50, Oliver Hartkopp wrote: >>> As reported by Manfred Schlaegl here >>> >>> http://marc.info/?l=linux-netdev&m=143482089824232&w=2 >>> >>> commit 514

Re: [PATCH - regression 4.1-rc8] can: fix loss of CAN frames in raw_rcv

2015-06-22 Thread Oliver Hartkopp
Hello Manfred, On 22.06.2015 12:10, Manfred Schlaegl wrote: On 2015-06-21 18:50, Oliver Hartkopp wrote: As reported by Manfred Schlaegl here http://marc.info/?l=linux-netdev&m=143482089824232&w=2 commit 514ac99c64b "can: fix multiple delivery of a single CAN frame for overlapping CAN filt

Re: [PATCH - regression 4.1-rc8] can: fix loss of CAN frames in raw_rcv

2015-06-22 Thread Manfred Schlaegl
Hello! On 2015-06-21 18:50, Oliver Hartkopp wrote: > As reported by Manfred Schlaegl here > >http://marc.info/?l=linux-netdev&m=143482089824232&w=2 > > commit 514ac99c64b "can: fix multiple delivery of a single CAN frame for > overlapping CAN filters" requires the skb->tstamp to be set to ch

Re: [PATCH - regression 4.1-rc8] can: fix loss of CAN frames in raw_rcv

2015-06-21 Thread Oliver Hartkopp
On 21.06.2015 18:57, Marc Kleine-Budde wrote: I'll send a pullrequest to David asap, I'll add stable on Cc if this doesn't make it into v4.1 anymore. Thanks Marc! I sent it to netdev and Dave directly too as he was working on his backlog - and I was not sure if you are available until the n

Re: [PATCH - regression 4.1-rc8] can: fix loss of CAN frames in raw_rcv

2015-06-21 Thread Marc Kleine-Budde
On 06/21/2015 06:50 PM, Oliver Hartkopp wrote: > As reported by Manfred Schlaegl here > >http://marc.info/?l=linux-netdev&m=143482089824232&w=2 > > commit 514ac99c64b "can: fix multiple delivery of a single CAN frame for > overlapping CAN filters" requires the skb->tstamp to be set to check f

[PATCH - regression 4.1-rc8] can: fix loss of CAN frames in raw_rcv

2015-06-21 Thread Oliver Hartkopp
As reported by Manfred Schlaegl here http://marc.info/?l=linux-netdev&m=143482089824232&w=2 commit 514ac99c64b "can: fix multiple delivery of a single CAN frame for overlapping CAN filters" requires the skb->tstamp to be set to check for identical CAN skbs. As net timestamping is influenced b