Re: [PATCH] xfrm: init skb_head lock for transport-mode packets

2018-01-04 Thread Artem Savkov
On Thu, Jan 04, 2018 at 10:01:32PM +1100, Herbert Xu wrote: > On Thu, Jan 04, 2018 at 11:36:28AM +0100, Artem Savkov wrote: > > Commit acf568ee859f "xfrm: Reinject transport-mode packets through tasklet" > > adds an sk_buff_head queue, but never initializes trans->queue.lock, which > > results in a

Re: [PATCH] xfrm: init skb_head lock for transport-mode packets

2018-01-04 Thread Herbert Xu
On Thu, Jan 04, 2018 at 11:36:28AM +0100, Artem Savkov wrote: > Commit acf568ee859f "xfrm: Reinject transport-mode packets through tasklet" > adds an sk_buff_head queue, but never initializes trans->queue.lock, which > results in a "spinlock bad magic" BUG on skb_queue_tail() call in > xfrm_trans_q

[PATCH] xfrm: init skb_head lock for transport-mode packets

2018-01-04 Thread Artem Savkov
Commit acf568ee859f "xfrm: Reinject transport-mode packets through tasklet" adds an sk_buff_head queue, but never initializes trans->queue.lock, which results in a "spinlock bad magic" BUG on skb_queue_tail() call in xfrm_trans_queue. Use skb_queue_head_init() instead of __skb_queue_head_init() to