On Thu, Feb 28, 2019 at 12:07:07PM +, Paul Durrant wrote:
> Yes, I meant kfree_skb(nskb).
>
In that case I think your patch looks fine.
Wei.
...@lists.xenproject.org;
> da...@davemloft.net
> Subject: Re: [Xen-devel] [PATCH] xen-netback: fix occasional leak of grant
> ref mappings under memory
> pressure
>
> > -Original Message-
> > From: Wei Liu [mailto:wei.l...@citrix.com]
> > Sent: 28 Februar
Subject: Re: [PATCH] xen-netback: fix occasional leak of grant ref mappings
> under memory pressure
>
> On 28/02/2019 11:21, Paul Durrant wrote:
> >>> @@ -1153,6 +1152,10 @@ static int xenvif_tx_submit(struct xenvif_queue
> >>> *q
On 28/02/2019 11:21, Paul Durrant wrote:
>>> @@ -1153,6 +1152,10 @@ static int xenvif_tx_submit(struct xenvif_queue
>>> *queue)
>>> kfree_skb(skb);
>>> continue;
>>> }
>>> +
>>> + /* Copie
.com]
> > > Sent: 28 February 2019 02:03
> > > To: xen-de...@lists.xenproject.org; netdev@vger.kernel.org;
> > > linux-ker...@vger.kernel.org
> > > Cc: Wei Liu ; Paul Durrant
> > > ; da...@davemloft.net;
> Igor
> > > Druzhinin
> > >
..@vger.kernel.org
> > Cc: Wei Liu ; Paul Durrant ;
> > da...@davemloft.net; Igor
> > Druzhinin
> > Subject: [PATCH] xen-netback: fix occasional leak of grant ref mappings
> > under memory pressure
> >
> > Zero-copy callback flag is not yet set on frag li
On 28/02/2019 02:03, Igor Druzhinin wrote:
> Zero-copy callback flag is not yet set on frag list skb at the moment
> xenvif_handle_frag_list() returns -ENOMEM. This eventually results in
> leaking grant ref mappings since xenvif_zerocopy_callback() is never
> called for these fragments. Those event
gt; Druzhinin
> Subject: [PATCH] xen-netback: fix occasional leak of grant ref mappings under
> memory pressure
>
> Zero-copy callback flag is not yet set on frag list skb at the moment
> xenvif_handle_frag_list() returns -ENOMEM. This eventually results in
> leaking grant ref ma
Zero-copy callback flag is not yet set on frag list skb at the moment
xenvif_handle_frag_list() returns -ENOMEM. This eventually results in
leaking grant ref mappings since xenvif_zerocopy_callback() is never
called for these fragments. Those eventually build up and cause Xen
to kill Dom0 as the sl
