Re: [PATCH] xdp: fix xsk_generic_xmit errno

2020-06-11 Thread David Miller
From: Li RongQing Date: Thu, 11 Jun 2020 13:11:06 +0800 > @@ -353,7 +353,6 @@ static int xsk_generic_xmit(struct sock *sk) > len = desc.len; > skb = sock_alloc_send_skb(sk, len, 1, &err); > if (unlikely(!skb)) { > - err = -EAGAIN; >

Re: [PATCH] xdp: fix xsk_generic_xmit errno

2020-06-11 Thread Daniel Borkmann
On 6/11/20 10:18 AM, Björn Töpel wrote: On Thu, 11 Jun 2020 at 07:11, Li RongQing wrote: propagate sock_alloc_send_skb error code, not set it to EAGAIN unconditionally, when fail to allocate skb, which maybe causes that user space unnecessary loops Fixes: 35fcde7f8deb "(xsk: support for Tx)"

Re: [PATCH] xdp: fix xsk_generic_xmit errno

2020-06-11 Thread Björn Töpel
On Thu, 11 Jun 2020 at 07:11, Li RongQing wrote: > > propagate sock_alloc_send_skb error code, not set it > to EAGAIN unconditionally, when fail to allocate skb, > which maybe causes that user space unnecessary loops > > Fixes: 35fcde7f8deb "(xsk: support for Tx)" > Signed-off-by: Li RongQing T

[PATCH] xdp: fix xsk_generic_xmit errno

2020-06-10 Thread Li RongQing
propagate sock_alloc_send_skb error code, not set it to EAGAIN unconditionally, when fail to allocate skb, which maybe causes that user space unnecessary loops Fixes: 35fcde7f8deb "(xsk: support for Tx)" Signed-off-by: Li RongQing --- net/xdp/xsk.c | 1 - 1 file changed, 1 deletion(-) diff --gi