Re: [PATCH] wan: new driver retina

2007-10-25 Thread Jeff Garzik
Not sure what's going on, but your patch looks scrambled, as scripts look at it: From: Matti Linnanvuori <[EMAIL PROTECTED]>=0A=0AAdding Retina G.7= 03 and G.SHDSL driver.=0A=0ASigned-off-by: Matti Linnanvuori =0A---=0A=0AFixing bugs and style according to netdev mailing= list comments.=0A=0

Re: [PATCH] wan: new driver retina

2007-10-22 Thread Krzysztof Halasa
A quick look only: Matti Linnanvuori <[EMAIL PROTECTED]> writes: > +++ linux-2.6.24/drivers/net/wan/retina.c > + CHANGES > + --- > + > + v1.0.0 (JK) - May 27, 2003: > + * Original driver. > + > + v1.1.0 (JK) - June, 2003: > +* final Flexibilis driver > + > + v1.2.

Re: [PATCH] wan: new driver retina

2007-10-22 Thread Randy Dunlap
On Mon, 22 Oct 2007 04:14:57 -0700 (PDT) Matti Linnanvuori wrote: > From: Matti Linnanvuori <[EMAIL PROTECTED]> > > Retina G.703 and G.SHDSL driver. > > Signed-off-by: Matti Linnanvuori <[EMAIL PROTECTED]> > --- Hi, Just a few basic questions... I'm not reviewing any of the code parts. > Fix