Re: [PATCH] vxlan: Accept user specified MTU value when create new vxlan link

2016-05-30 Thread Cong Wang
On Sat, May 28, 2016 at 8:22 AM, oc wrote: > 1. vxlan_dev_configure function check conf->mtu to determine if it need to > change value of dev->mtu. > The logical looks better to get conf->mtu from IFLA_MTU directly. Fair enough, Acked-by: Cong Wang

Re: [PATCH] vxlan: Accept user specified MTU value when create new vxlan link

2016-05-28 Thread oc
On 2016/05/28 00:09, Cong Wang wrote: On Thu, May 26, 2016 at 7:49 PM, Chen Haiquan wrote: When create a new vxlan link, example: ip link add vtap mtu 1440 type vxlan vni 1 dev eth0 The argument "mtu" has no effect, because it is not set to conf->mtu. The default value is used in vxlan_dev_

Re: [PATCH] vxlan: Accept user specified MTU value when create new vxlan link

2016-05-27 Thread Cong Wang
On Thu, May 26, 2016 at 7:49 PM, Chen Haiquan wrote: > When create a new vxlan link, example: > ip link add vtap mtu 1440 type vxlan vni 1 dev eth0 > > The argument "mtu" has no effect, because it is not set to conf->mtu. The > default value is used in vxlan_dev_configure function. > > This prob

[PATCH] vxlan: Accept user specified MTU value when create new vxlan link

2016-05-26 Thread Chen Haiquan
When create a new vxlan link, example: ip link add vtap mtu 1440 type vxlan vni 1 dev eth0 The argument "mtu" has no effect, because it is not set to conf->mtu. The default value is used in vxlan_dev_configure function. This problem was introduced by commit 0dfbdf4102b9 (vxlan: Factor out devic