Re: [PATCH] vmxnet3: avoid calling pskb_may_pull with interrupts disabled

2016-03-11 Thread Neil Horman
On Fri, Mar 11, 2016 at 11:41:42AM -0800, Shrikrishna Khare wrote: > > > On Fri, 11 Mar 2016, Tetsuo Handa wrote: > > > Neil Horman wrote: > > > On Mon, Mar 07, 2016 at 03:16:14PM -0500, David Miller wrote: > > > > From: Neil Horman > > > > Date: Fri, 4 Mar 2016 13:40:48 -0500 > > > > This pa

Re: [PATCH] vmxnet3: avoid calling pskb_may_pull with interrupts disabled

2016-03-11 Thread Shrikrishna Khare
On Fri, 11 Mar 2016, Tetsuo Handa wrote: > Neil Horman wrote: > > On Mon, Mar 07, 2016 at 03:16:14PM -0500, David Miller wrote: > > > From: Neil Horman > > > Date: Fri, 4 Mar 2016 13:40:48 -0500 > > This patch is calling spin_unlock_irqrestore() without spin_lock_irqsave(). > > In file inclu

Re: [PATCH] vmxnet3: avoid calling pskb_may_pull with interrupts disabled

2016-03-11 Thread Tetsuo Handa
Neil Horman wrote: > On Mon, Mar 07, 2016 at 03:16:14PM -0500, David Miller wrote: > > From: Neil Horman > > Date: Fri, 4 Mar 2016 13:40:48 -0500 This patch is calling spin_unlock_irqrestore() without spin_lock_irqsave(). In file included from include/linux/seqlock.h:35:0, from

Re: [PATCH] vmxnet3: avoid calling pskb_may_pull with interrupts disabled

2016-03-08 Thread Neil Horman
On Mon, Mar 07, 2016 at 03:16:14PM -0500, David Miller wrote: > From: Neil Horman > Date: Fri, 4 Mar 2016 13:40:48 -0500 > > > vmxnet3 has a function vmxnet3_parse_and_copy_hdr which, among other > > operations, > > uses pskb_may_pull to linearize the header portion of an skb. That > > operat

Re: [PATCH] vmxnet3: avoid calling pskb_may_pull with interrupts disabled

2016-03-07 Thread David Miller
From: Neil Horman Date: Fri, 4 Mar 2016 13:40:48 -0500 > vmxnet3 has a function vmxnet3_parse_and_copy_hdr which, among other > operations, > uses pskb_may_pull to linearize the header portion of an skb. That operation > eventually uses local_bh_disable/enable to ensure that it doesn't race wi

Re: [PATCH] vmxnet3: avoid calling pskb_may_pull with interrupts disabled

2016-03-04 Thread Shrikrishna Khare
On Fri, 4 Mar 2016, Neil Horman wrote: > vmxnet3 has a function vmxnet3_parse_and_copy_hdr which, among other > operations, > uses pskb_may_pull to linearize the header portion of an skb. That operation > eventually uses local_bh_disable/enable to ensure that it doesn't race with > the > driv

[PATCH] vmxnet3: avoid calling pskb_may_pull with interrupts disabled

2016-03-04 Thread Neil Horman
vmxnet3 has a function vmxnet3_parse_and_copy_hdr which, among other operations, uses pskb_may_pull to linearize the header portion of an skb. That operation eventually uses local_bh_disable/enable to ensure that it doesn't race with the drivers bottom half handler. Unfortunately, vmxnet3 preform