Re: [PATCH] via-velocity: don't oops on MTU change (resend)

2007-12-01 Thread Jeff Garzik
Stephen Hemminger wrote: The VIA veloicty driver needs the following to allow changing MTU when down. The buffer size needs to be computed when device is brought up, not when device is initialized. This also fixes a bug where the buffer size was computed differently on change_mtu versus initial

[PATCH] via-velocity: don't oops on MTU change (resend)

2007-11-28 Thread Stephen Hemminger
The VIA veloicty driver needs the following to allow changing MTU when down. The buffer size needs to be computed when device is brought up, not when device is initialized. This also fixes a bug where the buffer size was computed differently on change_mtu versus initial setting. Signed-off-by: St

Re: [PATCH] via-velocity: don't oops on MTU change.

2007-11-28 Thread Jon Nelson
Just a reminder: the following fix should (IMO) be considered for 2.6.24. The first patch does indeed fix the OOPS on MTU however subsequent MTU changes still OOPS. The below fixes that. I've been using both patches for over a week and they work just great. I noticed that the first fix made 2.6.24

Re: [PATCH] via-velocity: don't oops on MTU change.

2007-11-17 Thread Jarek Poplawski
Jon Nelson wrote, On 11/17/2007 01:59 AM: ... > OK. This is what I did. > Using git I grabbed a copy of Linus' tree and using the latest files > for via-velocity.[c,h], commit > 99fee6d7e5748d96884667a4628118f7fc130ea0, I determined that if I > backed out change 44c10138fd4bbc4b6d6bff0873c24902f2a

Re: [PATCH] via-velocity: don't oops on MTU change.

2007-11-16 Thread Jon Nelson
On 11/16/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > On Fri, 16 Nov 2007 10:21:25 -0600 > "Jon Nelson" <[EMAIL PROTECTED]> wrote: > > > I get a segmentation fault. > > > > Should this patch be in addition to the one from bug 9382? > > http://bugzilla.kernel.org/attachment.cgi?id=13555&action

Re: [PATCH] via-velocity: don't oops on MTU change.

2007-11-16 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Fri, 16 Nov 2007 08:47:06 -0800 > On Fri, 16 Nov 2007 10:21:25 -0600 > "Jon Nelson" <[EMAIL PROTECTED]> wrote: > > > I get a segmentation fault. > > > > Should this patch be in addition to the one from bug 9382? > > http://bugzilla.kernel.org/att

Re: [PATCH] via-velocity: don't oops on MTU change.

2007-11-16 Thread Stephen Hemminger
On Fri, 16 Nov 2007 10:21:25 -0600 "Jon Nelson" <[EMAIL PROTECTED]> wrote: > I get a segmentation fault. > > Should this patch be in addition to the one from bug 9382? > http://bugzilla.kernel.org/attachment.cgi?id=13555&action=view > Yes. The new patch adds just recomputes the rx buf size in on

Re: [PATCH] via-velocity: don't oops on MTU change.

2007-11-16 Thread Jon Nelson
I get a segmentation fault. Should this patch be in addition to the one from bug 9382? http://bugzilla.kernel.org/attachment.cgi?id=13555&action=view -- Jon - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at h

Re: [PATCH] via-velocity: don't oops on MTU change.

2007-11-15 Thread Stephen Hemminger
On Thu, 15 Nov 2007 20:42:55 -0600 "Jon Nelson" <[EMAIL PROTECTED]> wrote: > On 11/15/07, Jarek Poplawski <[EMAIL PROTECTED]> wrote: > .. > > > Sure! I was only worried velocity_open() treats dev->mtu > > a bit different than velocity_change_mtu(), so eg. after: > > > > velocity_change_mtu() // d

Re: [PATCH] via-velocity: don't oops on MTU change.

2007-11-15 Thread Stephen Hemminger
On Thu, 15 Nov 2007 20:42:55 -0600 "Jon Nelson" <[EMAIL PROTECTED]> wrote: > On 11/15/07, Jarek Poplawski <[EMAIL PROTECTED]> wrote: > .. > > > Sure! I was only worried velocity_open() treats dev->mtu > > a bit different than velocity_change_mtu(), so eg. after: > > > > velocity_change_mtu() // d

Re: [PATCH] via-velocity: don't oops on MTU change.

2007-11-15 Thread Jon Nelson
On 11/15/07, Jarek Poplawski <[EMAIL PROTECTED]> wrote: .. > Sure! I was only worried velocity_open() treats dev->mtu > a bit different than velocity_change_mtu(), so eg. after: > > velocity_change_mtu() // dev is down > velocity_open() > velocity_change_mtu() // dev is up > > with the same mtu, v

Re: [PATCH] via-velocity: don't oops on MTU change.

2007-11-15 Thread Jarek Poplawski
Stephen Hemminger wrote, On 11/15/2007 07:20 PM: > On Thu, 15 Nov 2007 09:26:00 +0100 > Jarek Poplawski <[EMAIL PROTECTED]> wrote: > >> On 15-11-2007 04:38, Stephen Hemminger wrote: >>> Simple mtu change when device is down. >>> Fix http://bugzilla.kernel.org/show_bug.cgi?id=9382. >>> >>> Signed-

Re: [PATCH] via-velocity: don't oops on MTU change.

2007-11-15 Thread Stephen Hemminger
On Thu, 15 Nov 2007 09:26:00 +0100 Jarek Poplawski <[EMAIL PROTECTED]> wrote: > On 15-11-2007 04:38, Stephen Hemminger wrote: > > Simple mtu change when device is down. > > Fix http://bugzilla.kernel.org/show_bug.cgi?id=9382. > > > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> > > > >

Re: [PATCH] via-velocity: don't oops on MTU change.

2007-11-15 Thread Jarek Poplawski
On 15-11-2007 04:38, Stephen Hemminger wrote: > Simple mtu change when device is down. > Fix http://bugzilla.kernel.org/show_bug.cgi?id=9382. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> > > > --- a/drivers/net/via-velocity.c 2007-10-22 09:38:11.0 -0700 > +++ b/drivers/n

Re: [PATCH] via-velocity: don't oops on MTU change.

2007-11-14 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 19:38:44 -0800 > Simple mtu change when device is down. > Fix http://bugzilla.kernel.org/show_bug.cgi?id=9382. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied. Thanks for looking at this bug so quickly Stephen.

[PATCH] via-velocity: don't oops on MTU change.

2007-11-14 Thread Stephen Hemminger
Simple mtu change when device is down. Fix http://bugzilla.kernel.org/show_bug.cgi?id=9382. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/via-velocity.c2007-10-22 09:38:11.0 -0700 +++ b/drivers/net/via-velocity.c2007-11-14 19:34:30.0 -0800