Re: [PATCH] vhost: make msg padding explicit

2018-05-02 Thread Kevin Easton
On Wed, May 02, 2018 at 05:19:27PM +0300, Michael S. Tsirkin wrote: > On Wed, May 02, 2018 at 10:04:46AM -0400, David Miller wrote: > > From: "Michael S. Tsirkin" > > Date: Wed, 2 May 2018 16:36:37 +0300 > > > > > Ouch. True - and in particular the 32 bit ABI on 64 bit kernels doesn't > > > work

Re: [PATCH] vhost: make msg padding explicit

2018-05-02 Thread Michael S. Tsirkin
On Wed, May 02, 2018 at 10:04:46AM -0400, David Miller wrote: > From: "Michael S. Tsirkin" > Date: Wed, 2 May 2018 16:36:37 +0300 > > > Ouch. True - and in particular the 32 bit ABI on 64 bit kernels doesn't > > work at all. Hmm. It's relatively new and maybe there aren't any 32 bit > > users ye

Re: [PATCH] vhost: make msg padding explicit

2018-05-02 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 2 May 2018 16:36:37 +0300 > Ouch. True - and in particular the 32 bit ABI on 64 bit kernels doesn't > work at all. Hmm. It's relatively new and maybe there aren't any 32 bit > users yet. Thoughts? If it's been in a released kernel version, we really aren't

Re: [PATCH] vhost: make msg padding explicit

2018-05-02 Thread Michael S. Tsirkin
On Wed, May 02, 2018 at 02:28:09AM -0400, Kevin Easton wrote: > On Tue, May 01, 2018 at 02:05:51PM -0400, David Miller wrote: > > From: "Michael S. Tsirkin" > > Date: Tue, 1 May 2018 20:19:19 +0300 > > > > > On Tue, May 01, 2018 at 11:28:22AM -0400, David Miller wrote: > > >> From: "Michael S. Ts

Re: [PATCH] vhost: make msg padding explicit

2018-05-01 Thread Kevin Easton
On Tue, May 01, 2018 at 02:05:51PM -0400, David Miller wrote: > From: "Michael S. Tsirkin" > Date: Tue, 1 May 2018 20:19:19 +0300 > > > On Tue, May 01, 2018 at 11:28:22AM -0400, David Miller wrote: > >> From: "Michael S. Tsirkin" > >> Date: Fri, 27 Apr 2018 19:02:05 +0300 > >> > >> > There's a

Re: [PATCH] vhost: make msg padding explicit

2018-05-01 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 1 May 2018 20:19:19 +0300 > On Tue, May 01, 2018 at 11:28:22AM -0400, David Miller wrote: >> From: "Michael S. Tsirkin" >> Date: Fri, 27 Apr 2018 19:02:05 +0300 >> >> > There's a 32 bit hole just after type. It's best to >> > give it a name, this way compil

Re: [PATCH] vhost: make msg padding explicit

2018-05-01 Thread Michael S. Tsirkin
On Tue, May 01, 2018 at 11:28:22AM -0400, David Miller wrote: > From: "Michael S. Tsirkin" > Date: Fri, 27 Apr 2018 19:02:05 +0300 > > > There's a 32 bit hole just after type. It's best to > > give it a name, this way compiler is forced to initialize > > it with rest of the structure. > > > > Re

Re: [PATCH] vhost: make msg padding explicit

2018-05-01 Thread David Miller
From: "Michael S. Tsirkin" Date: Fri, 27 Apr 2018 19:02:05 +0300 > There's a 32 bit hole just after type. It's best to > give it a name, this way compiler is forced to initialize > it with rest of the structure. > > Reported-by: Kevin Easton > Signed-off-by: Michael S. Tsirkin Michael, will y

Re: [PATCH] vhost: make msg padding explicit

2018-04-29 Thread David Miller
From: "Michael S. Tsirkin" Date: Fri, 27 Apr 2018 19:02:05 +0300 > There's a 32 bit hole just after type. It's best to > give it a name, this way compiler is forced to initialize > it with rest of the structure. > > Reported-by: Kevin Easton > Signed-off-by: Michael S. Tsirkin Who applied thi

[PATCH] vhost: make msg padding explicit

2018-04-27 Thread Michael S. Tsirkin
There's a 32 bit hole just after type. It's best to give it a name, this way compiler is forced to initialize it with rest of the structure. Reported-by: Kevin Easton Signed-off-by: Michael S. Tsirkin --- include/uapi/linux/vhost.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uap