Re: [PATCH] v2 Check for SKBTX_HW_TSTAMP in macb driver

2019-04-04 Thread Paul Thomas
On Thu, Apr 4, 2019 at 9:23 AM Paul Thomas wrote: > > > Could you please resend the patch addressing Dave's review comments > > about subject line and Fixes tag? > Yup, sorry about that. I'm not subscribed to netdev, but I thought > replies would have me in the to:line, but I see the comments on t

Re: [PATCH] v2 Check for SKBTX_HW_TSTAMP in macb driver

2019-04-04 Thread Paul Thomas
> Could you please resend the patch addressing Dave's review comments > about subject line and Fixes tag? Yup, sorry about that. I'm not subscribed to netdev, but I thought replies would have me in the to:line, but I see the comments on the archive. I'll send this out shortly. -Paul

Re: [PATCH] v2 Check for SKBTX_HW_TSTAMP in macb driver

2019-04-04 Thread Harini Katakam
Hi Paul, On Thu, Apr 4, 2019 at 6:35 PM Paul Thomas wrote: > > On Tue, Mar 19, 2019 at 1:07 PM Paul Thomas wrote: > > > Hi All, just a reminder on this. Could you please resend the patch addressing Dave's review comments about subject line and Fixes tag? Regards, Harini

Re: [PATCH] v2 Check for SKBTX_HW_TSTAMP in macb driver

2019-04-04 Thread Paul Thomas
On Tue, Mar 19, 2019 at 1:07 PM Paul Thomas wrote: > > Make sure SKBTX_HW_TSTAMP (i.e. SOF_TIMESTAMPING_TX_HARDWARE) has been > enabled for this skb It does fix the issue where normal socks that > aren't expecting a timestamp will not wake up on select. And when a > user does want a SOF_TIMESTAMPI

Re: [PATCH] v2 Check for SKBTX_HW_TSTAMP in macb driver

2019-03-20 Thread David Miller
Paul, please format your patch properly. The Subject line should be of the form: [PATCH vX] $subsystem-prefix: Description. Also please provide an accurate and proper Fixes: tag. Thank you.

Re: [PATCH] v2 Check for SKBTX_HW_TSTAMP in macb driver

2019-03-19 Thread Harini Katakam
Hi Paul, On Tue, Mar 19, 2019 at 11:13 PM Paul Thomas wrote: > > Oh I notice that this is in the xilnx github repo so if it makes it in > from there that works too. No, I don't plan to send anything. I just used your patch (retained your signed-off, of course) and added the && check, because I w

Re: [PATCH] v2 Check for SKBTX_HW_TSTAMP in macb driver

2019-03-19 Thread Paul Thomas
Oh I notice that this is in the xilnx github repo so if it makes it in from there that works too. -Paul

[PATCH] v2 Check for SKBTX_HW_TSTAMP in macb driver

2019-03-19 Thread Paul Thomas
Make sure SKBTX_HW_TSTAMP (i.e. SOF_TIMESTAMPING_TX_HARDWARE) has been enabled for this skb It does fix the issue where normal socks that aren't expecting a timestamp will not wake up on select. And when a user does want a SOF_TIMESTAMPING_TX_HARDWARE this does work. Signed-off-by: Paul Thomas --