Re: [PATCH] unix_diag: fix incorrect sign extension in unix_lookup_by_ino

2016-02-19 Thread David Miller
From: Cong Wang Date: Fri, 19 Feb 2016 16:21:14 -0800 > On Thu, Feb 18, 2016 at 5:27 PM, Dmitry V. Levin wrote: >> The value passed by unix_diag_get_exact to unix_lookup_by_ino has type >> __u32, but unix_lookup_by_ino's argument ino has type int, which is not >> a problem yet. >> However, when

Re: [PATCH] unix_diag: fix incorrect sign extension in unix_lookup_by_ino

2016-02-19 Thread Cong Wang
On Thu, Feb 18, 2016 at 5:27 PM, Dmitry V. Levin wrote: > The value passed by unix_diag_get_exact to unix_lookup_by_ino has type > __u32, but unix_lookup_by_ino's argument ino has type int, which is not > a problem yet. > However, when ino is compared with sock_i_ino return value of type > unsigne

[PATCH] unix_diag: fix incorrect sign extension in unix_lookup_by_ino

2016-02-18 Thread Dmitry V. Levin
The value passed by unix_diag_get_exact to unix_lookup_by_ino has type __u32, but unix_lookup_by_ino's argument ino has type int, which is not a problem yet. However, when ino is compared with sock_i_ino return value of type unsigned long, ino is sign extended to signed long, and this results to in