Re: [PATCH] umh: fix memory leak on execve failure

2020-05-08 Thread Jakub Kicinski
On Fri, 8 May 2020 00:14:22 +0200 Vincent Minet wrote: > If a UMH process created by fork_usermode_blob() fails to execute, > a pair of struct file allocated by umh_pipe_setup() will leak. > > Under normal conditions, the caller (like bpfilter) needs to manage the > lifetime of the UMH and its tw

[PATCH] umh: fix memory leak on execve failure

2020-05-07 Thread Vincent Minet
If a UMH process created by fork_usermode_blob() fails to execute, a pair of struct file allocated by umh_pipe_setup() will leak. Under normal conditions, the caller (like bpfilter) needs to manage the lifetime of the UMH and its two pipes. But when fork_usermode_blob() fails, the caller doesn't r