On 11/24/2015 12:35 PM, David Miller wrote:
> pskb_expand_head() returns negative error codes, therefore zero means
> success and therefore this "!err" check is reversed.
Thank you for pointing out such a stupid mistake I made.
I will send v2 to correct it.
Regards,
Ying
--
To unsubscribe from
From: Ying Xue
Date: Sun, 22 Nov 2015 15:38:39 +0800
> @@ -158,8 +158,11 @@ static int tipc_udp_send_msg(struct net *net, struct
> sk_buff *skb,
> struct udp_media_addr *src = (struct udp_media_addr *)&b->addr.value;
> struct rtable *rt;
>
> - if (skb_headroom(skb) < UDP_MIN_HE
Coverity says:
*** CID 1338065: Error handling issues (CHECKED_RETURN)
/net/tipc/udp_media.c: 162 in tipc_udp_send_msg()
156 struct udp_media_addr *dst = (struct udp_media_addr
*)&dest->value;
157 struct udp_media_addr *src = (struct udp_media_addr
*)&b->addr.value;
158
