Re: [PATCH] tg3: ethtool phys_id default (rev2)

2008-02-25 Thread Eliezer Tamir
> > Doesn't this mean that ethtool -p will hold the RTNL lock forever? > > Is this a good idea? > > > > For example on the Red Hat machine I have here if you do: > > > > ethtool -p eth2 10 & > > reboot > > > > Various things the shutdown scripts try to do will fail because of the > > held RT

Re: [PATCH] tg3: ethtool phys_id default (rev2)

2008-02-25 Thread Stephen Hemminger
On Sun, 24 Feb 2008 07:42:06 +0200 "Eliezer Tamir" <[EMAIL PROTECTED]> wrote: > > On Sat, 2008-02-23 at 19:52 -0800, David Miller wrote: > > From: "Michael Chan" <[EMAIL PROTECTED]> > > Date: Fri, 22 Feb 2008 11:16:42 -0800 > > > > > On Fri, 2008-02-22 at 10:24 -0800, Stephen Hemminger wrote: >

Re: [PATCH] tg3: ethtool phys_id default (rev2)

2008-02-23 Thread Eliezer Tamir
On Sat, 2008-02-23 at 19:52 -0800, David Miller wrote: > From: "Michael Chan" <[EMAIL PROTECTED]> > Date: Fri, 22 Feb 2008 11:16:42 -0800 > > > On Fri, 2008-02-22 at 10:24 -0800, Stephen Hemminger wrote: > > > When asked to blink LEDs the tg3 driver behaves when using: > > > ethtool -p ethX > >

Re: [PATCH] tg3: ethtool phys_id default (rev2)

2008-02-23 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Fri, 22 Feb 2008 11:16:42 -0800 > On Fri, 2008-02-22 at 10:24 -0800, Stephen Hemminger wrote: > > When asked to blink LEDs the tg3 driver behaves when using: > > ethtool -p ethX > > The default value for data is zero, and other drivers interpret t

Re: [PATCH] tg3: ethtool phys_id default (rev2)

2008-02-22 Thread Michael Chan
On Fri, 2008-02-22 at 10:24 -0800, Stephen Hemminger wrote: > When asked to blink LEDs the tg3 driver behaves when using: > ethtool -p ethX > The default value for data is zero, and other drivers interpret this > as blink forever (or at least a really long time). The tg3 driver > interprets