Re: [PATCH] test_bpf: fix the dummy skb after dissector changes

2016-09-15 Thread David Miller
From: Jakub Kicinski Date: Mon, 12 Sep 2016 13:04:57 +0100 > Commit d5709f7ab776 ("flow_dissector: For stripped vlan, get vlan > info from skb->vlan_tci") made flow dissector look at vlan_proto > when vlan is present. Since test_bpf sets skb->vlan_tci to ~0 > (including VLAN_TAG_PRESENT) we have

Re: [PATCH] test_bpf: fix the dummy skb after dissector changes

2016-09-12 Thread Alexei Starovoitov
On Mon, Sep 12, 2016 at 01:04:57PM +0100, Jakub Kicinski wrote: > Commit d5709f7ab776 ("flow_dissector: For stripped vlan, get vlan > info from skb->vlan_tci") made flow dissector look at vlan_proto > when vlan is present. Since test_bpf sets skb->vlan_tci to ~0 > (including VLAN_TAG_PRESENT) we h

Re: [PATCH] test_bpf: fix the dummy skb after dissector changes

2016-09-12 Thread Daniel Borkmann
On 09/12/2016 02:04 PM, Jakub Kicinski wrote: Commit d5709f7ab776 ("flow_dissector: For stripped vlan, get vlan info from skb->vlan_tci") made flow dissector look at vlan_proto when vlan is present. Since test_bpf sets skb->vlan_tci to ~0 (including VLAN_TAG_PRESENT) we have to populate skb->vla

[PATCH] test_bpf: fix the dummy skb after dissector changes

2016-09-12 Thread Jakub Kicinski
Commit d5709f7ab776 ("flow_dissector: For stripped vlan, get vlan info from skb->vlan_tci") made flow dissector look at vlan_proto when vlan is present. Since test_bpf sets skb->vlan_tci to ~0 (including VLAN_TAG_PRESENT) we have to populate skb->vlan_proto. Fixes false negative on test #24: test