Re: [PATCH] tehuti: possible leak in bdx_probe

2007-10-15 Thread Jeff Garzik
Florin Malita wrote: If pci_enable_device fails, bdx_probe returns without freeing the allocated pci_nic structure. Coverity CID 1908. Signed-off-by: Florin Malita <[EMAIL PROTECTED]> --- drivers/net/tehuti.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) applied - To unsubscri

Re: [PATCH] tehuti: possible leak in bdx_probe

2007-10-15 Thread Andy Gospodarek
On Sat, Oct 13, 2007 at 01:03:38PM -0400, Florin Malita wrote: > If pci_enable_device fails, bdx_probe returns without freeing the > allocated pci_nic structure. > > Coverity CID 1908. > > Signed-off-by: Florin Malita <[EMAIL PROTECTED]> > --- > > drivers/net/tehuti.c |3 ++- > 1 file change

RE: [PATCH] tehuti: possible leak in bdx_probe

2007-10-14 Thread Alexander Indenbaum
> -Original Message- > From: Florin Malita [mailto:[EMAIL PROTECTED] > > If pci_enable_device fails, bdx_probe returns without freeing the > allocated pci_nic structure. > > Coverity CID 1908. > > Signed-off-by: Florin Malita <[EMAIL PROTECTED]> Looks fine to me. Acked-by: Alexander In

[PATCH] tehuti: possible leak in bdx_probe

2007-10-13 Thread Florin Malita
If pci_enable_device fails, bdx_probe returns without freeing the allocated pci_nic structure. Coverity CID 1908. Signed-off-by: Florin Malita <[EMAIL PROTECTED]> --- drivers/net/tehuti.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/tehuti.c b/drivers/net