Re: [PATCH] tcp: set congestion default through Kconfig (v2)

2006-09-19 Thread bert hubert
On Tue, Sep 19, 2006 at 02:20:07PM -0700, David Miller wrote: > > Bert's attempt was noble > > It showed your desire for the truth It was also crap :-) > Applied, but... > net/ipv4/Kconfig:607:warning: defaults for choice values not supported It does appear to do the right thing in all cases I

Re: [PATCH] tcp: set congestion default through Kconfig (v2)

2006-09-19 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 19 Sep 2006 13:41:32 -0700 > Bert's attempt was noble > It showed your desire for the truth > A simple path existed > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied, but... net/ipv4/Kconfig:607:warning: defaults for choice v

[PATCH] tcp: set congestion default through Kconfig (v2)

2006-09-19 Thread Stephen Hemminger
Bert's attempt was noble It showed your desire for the truth A simple path existed Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net/ipv4/Kconfig | 39 +-- net/ipv4/sysctl_net_ipv4.c |6 ++ net/ipv4/tcp_cong.c|2 +- 3

Re: [PATCH] tcp: set congestion default through Kconfig

2006-09-19 Thread Stephen Hemminger
It built (and ran) for me. But that was on a different machine. Perhaps there was some git confusion, I'll go back to using quilt it gives me less grief. -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL

Re: [PATCH] tcp: set congestion default through Kconfig

2006-09-19 Thread David Miller
Ok, I really give up, after adding the missing semicolon I now get this: net/ipv4/sysctl_net_ipv4.c:136: warning: initialization from incompatible pointer type This is getting rediculious. Folks, don't post patches which are not "request for comments" explicitly in the subject line without tes

Re: [PATCH] tcp: set congestion default through Kconfig

2006-09-19 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 18 Sep 2006 21:41:04 -0700 > Bert's attempt was noble > It showed your desire for the truth > A simple path exists > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Looks good, applied. - To unsubscribe from this list: send the line "

Re: [PATCH] tcp: set congestion default through Kconfig

2006-09-19 Thread David Miller
Actually, I take that back: net/ipv4/sysctl_net_ipv4.c: In function $,1rx(Btcp_congestion_default$,1ry(B: net/ipv4/sysctl_net_ipv4.c:134: error: syntax error before $,1rx(B}$,1ry(B token net/ipv4/sysctl_net_ipv4.c: At top level: net/ipv4/sysctl_net_ipv4.c:136: warning: initialization fr

Re: [PATCH] tcp: set congestion default through Kconfig

2006-09-19 Thread Stephen Hemminger
On Tue, 19 Sep 2006 09:10:37 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Hagen Paul Pfeifer <[EMAIL PROTECTED]> > Date: Tue, 19 Sep 2006 14:35:35 +0200 > > > BTW: BIC is sometimes to aggressive in comparison to standard tcp > > behaviour (e.g. in short RTT environments) - this is

Re: [PATCH] tcp: set congestion default through Kconfig

2006-09-19 Thread David Miller
From: Hagen Paul Pfeifer <[EMAIL PROTECTED]> Date: Tue, 19 Sep 2006 14:35:35 +0200 > BTW: BIC is sometimes to aggressive in comparison to standard tcp > behaviour (e.g. in short RTT environments) - this is an known > issue. Why not cubic as the default one? We may change over to CUBIC as the defa

Re: [PATCH] tcp: set congestion default through Kconfig

2006-09-19 Thread Stephen Hemminger
On Tue, 19 Sep 2006 12:03:51 +0200 Andi Kleen <[EMAIL PROTECTED]> wrote: > On Tuesday 19 September 2006 06:41, Stephen Hemminger wrote: > > Bert's attempt was noble > > It showed your desire for the truth > > A simple path exists > > I guess most people won't have a clue on what to configure here

Re: [PATCH] tcp: set congestion default through Kconfig

2006-09-19 Thread Hagen Paul Pfeifer
* Andi Kleen | 2006-09-19 12:03:51 [+0200]: >How about a single auto selection heuristic: e.g. check the handshake >latencies >and if they are too long switch from reno to the newer one deemed most >stable? Thats absolute no practicable solution to discover the 'right' algorithm. The latenzy is

Re: [PATCH] tcp: set congestion default through Kconfig

2006-09-19 Thread Andi Kleen
On Tuesday 19 September 2006 06:41, Stephen Hemminger wrote: > Bert's attempt was noble > It showed your desire for the truth > A simple path exists I guess most people won't have a clue on what to configure here (especially with such sparse help text, but even with more it would be hard). And

Re: [PATCH] tcp: set congestion default through Kconfig

2006-09-18 Thread Ian McDonald
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net/ipv4/Kconfig | 39 +-- net/ipv4/sysctl_net_ipv4.c |7 +++ net/ipv4/tcp_cong.c|2 +- 3 files changed, 45 insertions(+), 3 deletions(-) Nice solution. Signed-off-by: I

[PATCH] tcp: set congestion default through Kconfig

2006-09-18 Thread Stephen Hemminger
Bert's attempt was noble It showed your desire for the truth A simple path exists Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net/ipv4/Kconfig | 39 +-- net/ipv4/sysctl_net_ipv4.c |7 +++ net/ipv4/tcp_cong.c|2 +- 3