Re: [PATCH] tcp: Don't access TCP_SKB_CB before initializing it

2019-03-11 Thread David Miller
From: Christoph Paasch Date: Mon, 11 Mar 2019 11:41:05 -0700 > Since commit eeea10b83a13 ("tcp: add > tcp_v4_fill_cb()/tcp_v4_restore_cb()"), tcp_vX_fill_cb is only called > after tcp_filter(). That means, TCP_SKB_CB(skb)->end_seq still points to > the IP-part of the cb. > > We thus should not m

Re: [PATCH] tcp: Don't access TCP_SKB_CB before initializing it

2019-03-11 Thread Eric Dumazet
On 03/11/2019 11:41 AM, Christoph Paasch wrote: > Since commit eeea10b83a13 ("tcp: add > tcp_v4_fill_cb()/tcp_v4_restore_cb()"), tcp_vX_fill_cb is only called > after tcp_filter(). That means, TCP_SKB_CB(skb)->end_seq still points to > the IP-part of the cb. > > We thus should not mock with it,

[PATCH] tcp: Don't access TCP_SKB_CB before initializing it

2019-03-11 Thread Christoph Paasch
Since commit eeea10b83a13 ("tcp: add tcp_v4_fill_cb()/tcp_v4_restore_cb()"), tcp_vX_fill_cb is only called after tcp_filter(). That means, TCP_SKB_CB(skb)->end_seq still points to the IP-part of the cb. We thus should not mock with it, as this can trigger bugs (thanks syzkaller): [ 12.349396] =