Re: [PATCH] tbf scheduler: TSO support (updated)

2007-05-13 Thread Herbert Xu
Hirokazu Takahashi <[EMAIL PROTECTED]> wrote: > > Uhh, you are right. > skb_shinfo(skb)->gso_segs and skb_shinfo(skb)->gso_size should be used. Actually forget about gso_segs, it's only filled in for TCP. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL

Re: [PATCH] tbf scheduler: TSO support (updated)

2007-05-13 Thread Hirokazu Takahashi
Hi, > > > I'm now thinking I can make it just hold a TSO packet until > > > p->tokens reaches the size of the packet. I think it is > > > straightforward implementation. I'll try this. > > > > I re-implemented the patch, which is simpler than the previous one. > > > > sch->dev->mtu is used to de

Re: [PATCH] tbf scheduler: TSO support (updated)

2007-05-13 Thread Stephen Hemminger
On Sun, 13 May 2007 21:42:36 +0900 (JST) Hirokazu Takahashi <[EMAIL PROTECTED]> wrote: > Hi, > > > I'm now thinking I can make it just hold a TSO packet until > > p->tokens reaches the size of the packet. I think it is > > straightforward implementation. I'll try this. > > I re-implemented the p

[PATCH] tbf scheduler: TSO support (updated)

2007-05-13 Thread Hirokazu Takahashi
Hi, > I'm now thinking I can make it just hold a TSO packet until p->tokens > reaches the size of the packet. I think it is straightforward > implementation. I'll try this. I re-implemented the patch, which is simpler than the previous one. sch->dev->mtu is used to determine how many segments ar

Re: [PATCH] tbf scheduler: TSO support

2007-05-12 Thread Hirokazu Takahashi
Hi, > > > I think the concept of TBF is quit good but the userspace tools have > > > become old that it doesn't fit to Gb ethernet environment. > > > The tools should be updated to care about much faster network and > > > GbE jumbo frames. I agree with you at this point. > > > > > > On the other

Re: [PATCH] tbf scheduler: TSO support

2007-05-12 Thread Hirokazu Takahashi
Hi, > > I think the concept of TBF is quit good but the userspace tools have > > become old that it doesn't fit to Gb ethernet environment. > > The tools should be updated to care about much faster network and > > GbE jumbo frames. I agree with you at this point. > > > > On the other hand, handli

Re: [PATCH] tbf scheduler: TSO support

2007-05-11 Thread Patrick McHardy
Hirokazu Takahashi wrote: > I think the concept of TBF is quit good but the userspace tools have > become old that it doesn't fit to Gb ethernet environment. > The tools should be updated to care about much faster network and > GbE jumbo frames. I agree with you at this point. > > On the other han

Re: [PATCH] tbf scheduler: TSO support

2007-05-10 Thread Hirokazu Takahashi
Hi, > >>I don't see why this is needed, the correct way to use TBF with TSO > >>is to specify a larger MTU value, in which case it won't drop TSO > >>packets. > > > > > > Why should a user have to know anything in the world about TSO in > > order to configure TBF properly? I don't think they sh

Re: [PATCH] tbf scheduler: TSO support

2007-05-10 Thread Patrick McHardy
David Miller wrote: > From: Patrick McHardy <[EMAIL PROTECTED]> > Date: Thu, 10 May 2007 14:56:39 +0200 > >>I don't see why this is needed, the correct way to use TBF with TSO >>is to specify a larger MTU value, in which case it won't drop TSO >>packets. > > > Why should a user have to know anyt

Re: [PATCH] tbf scheduler: TSO support

2007-05-10 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 10 May 2007 14:56:39 +0200 > Hirokazu Takahashi wrote: > > TBF --- Simple Token Bucket Filter --- packet scheduler doesn't > > work correctly with TSO on that it slows down to send out packets. > > TSO packets will be discarded since the size ca

Re: [PATCH] tbf scheduler: TSO support

2007-05-10 Thread Patrick McHardy
Hirokazu Takahashi wrote: > TBF --- Simple Token Bucket Filter --- packet scheduler doesn't > work correctly with TSO on that it slows down to send out packets. > TSO packets will be discarded since the size can be larger than > the scheduler expects. But it won't cause serious problems > because t

[PATCH] tbf scheduler: TSO support

2007-05-10 Thread Hirokazu Takahashi
Hi, TBF --- Simple Token Bucket Filter --- packet scheduler doesn't work correctly with TSO on that it slows down to send out packets. TSO packets will be discarded since the size can be larger than the scheduler expects. But it won't cause serious problems because the retransmitted packets can be

Re: [PATCH] tbf scheduler: TSO support

2007-05-10 Thread Patrick McHardy
Hirokazu Takahashi wrote: > TBF --- Simple Token Bucket Filter --- packet scheduler doesn't > work correctly with TSO on that it slows down to send out packets. > TSO packets will be discarded since the size can be larger than > the scheduler expects. But it won't cause serious problems > because t