Re: [PATCH] sysctl: fix unused function warning

2020-05-05 Thread Alexei Starovoitov
On Tue, May 5, 2020 at 11:25 AM Song Liu wrote: > > > > > On May 5, 2020, at 7:07 AM, Arnd Bergmann wrote: > > > > The newly added bpf_stats_handler function has the wrong #ifdef > > check around it, leading to an unused-function warning when > > CONFIG_SYSCTL is disabled: > > > > kernel/sysctl.c

Re: [PATCH] sysctl: fix unused function warning

2020-05-05 Thread Song Liu
> On May 5, 2020, at 7:07 AM, Arnd Bergmann wrote: > > The newly added bpf_stats_handler function has the wrong #ifdef > check around it, leading to an unused-function warning when > CONFIG_SYSCTL is disabled: > > kernel/sysctl.c:205:12: error: unused function 'bpf_stats_handler' > [-Werror,

Re: [PATCH] sysctl: fix unused function warning

2020-05-05 Thread Luis Chamberlain
On Tue, May 05, 2020 at 04:07:12PM +0200, Arnd Bergmann wrote: > The newly added bpf_stats_handler function has the wrong #ifdef > check around it, leading to an unused-function warning when > CONFIG_SYSCTL is disabled: > > kernel/sysctl.c:205:12: error: unused function 'bpf_stats_handler' > [-We

Re: [PATCH] sysctl: fix unused function warning

2020-05-05 Thread Martin KaFai Lau
On Tue, May 05, 2020 at 04:07:12PM +0200, Arnd Bergmann wrote: > The newly added bpf_stats_handler function has the wrong #ifdef > check around it, leading to an unused-function warning when > CONFIG_SYSCTL is disabled: > > kernel/sysctl.c:205:12: error: unused function 'bpf_stats_handler' > [-We

[PATCH] sysctl: fix unused function warning

2020-05-05 Thread Arnd Bergmann
The newly added bpf_stats_handler function has the wrong #ifdef check around it, leading to an unused-function warning when CONFIG_SYSCTL is disabled: kernel/sysctl.c:205:12: error: unused function 'bpf_stats_handler' [-Werror,-Wunused-function] static int bpf_stats_handler(struct ctl_table *tabl