Re: [PATCH] stmmac: explicitly zero des0 & des1 on init

2015-06-24 Thread David Miller
From: Alexey Brodkin Date: Tue, 23 Jun 2015 15:04:31 + > I'm wondering if my comment makes sense and should I just change commit > message or you'd prefer to still use dma_zalloc_coherent() during > driver probe? I think you should do both, convert to dma_zalloc_coherent() and perform the ex

Re: [PATCH] stmmac: explicitly zero des0 & des1 on init

2015-06-23 Thread Alexey Brodkin
Hi David, On Mon, 2015-06-22 at 09:43 +0300, Alexey Brodkin wrote: > Hi David, > > On Sun, 2015-06-21 at 09:29 -0700, David Miller wrote: > > From: Alexey Brodkin > > Date: Tue, 16 Jun 2015 20:40:41 +0300 > > > > > Current implementtion of descriptor init procedure only takes > > > care > > >

Re: [arc-linux-dev] [PATCH] stmmac: explicitly zero des0 & des1 on init

2015-06-22 Thread Vineet Gupta
On Monday 22 June 2015 01:38 PM, Alexey Brodkin wrote: > Hi all, > > On Wed, 2015-06-17 at 07:03 +, Vineet Gupta wrote: > +CC linux-arch, linux-mm, Arnd and Marek > > On Tuesday 16 June 2015 11:11 PM, Alexey Brodkin wrote: > > Current implementtion of descriptor init procedure only takes car

Re: [arc-linux-dev] [PATCH] stmmac: explicitly zero des0 & des1 on init

2015-06-22 Thread Alexey Brodkin
Hi all, On Wed, 2015-06-17 at 07:03 +, Vineet Gupta wrote: +CC linux-arch, linux-mm, Arnd and Marek On Tuesday 16 June 2015 11:11 PM, Alexey Brodkin wrote: Current implementtion of descriptor init procedure only takes care about ownership flag. While it is perfectly possible to have underlyi

Re: [PATCH] stmmac: explicitly zero des0 & des1 on init

2015-06-21 Thread Alexey Brodkin
Hi David, On Sun, 2015-06-21 at 09:29 -0700, David Miller wrote: > From: Alexey Brodkin > Date: Tue, 16 Jun 2015 20:40:41 +0300 > > > Current implementtion of descriptor init procedure only takes care > > about > > ownership flag. While it is perfectly possible to have underlying > > memory >

Re: [PATCH] stmmac: explicitly zero des0 & des1 on init

2015-06-21 Thread David Miller
From: Alexey Brodkin Date: Tue, 16 Jun 2015 20:40:41 +0300 > Current implementtion of descriptor init procedure only takes care about > ownership flag. While it is perfectly possible to have underlying memory > filled with garbage on boot or driver installation. > > And randomly set flags in non

Re: [arc-linux-dev] [PATCH] stmmac: explicitly zero des0 & des1 on init

2015-06-17 Thread Vineet Gupta
+CC linux-arch, linux-mm, Arnd and Marek On Tuesday 16 June 2015 11:11 PM, Alexey Brodkin wrote: Current implementtion of descriptor init procedure only takes care about ownership flag. While it is perfectly possible to have underlying memory filled with garbage on boot or driver installation. A

[PATCH] stmmac: explicitly zero des0 & des1 on init

2015-06-16 Thread Alexey Brodkin
Current implementtion of descriptor init procedure only takes care about ownership flag. While it is perfectly possible to have underlying memory filled with garbage on boot or driver installation. And randomly set flags in non-zeroed des0 and des1 fields may lead to unpredictable behavior of the