Re: [PATCH] stating: octeon: Drop on uncorrectable alignment or FCS error

2020-10-12 Thread Alexander Sverdlin
Hello Dan, On 09/10/2020 14:24, Dan Carpenter wrote: > On Fri, Oct 09, 2020 at 11:46:05AM +0200, Alexander A Sverdlin wrote: >> --- a/drivers/staging/octeon/ethernet-rx.c >> +++ b/drivers/staging/octeon/ethernet-rx.c >> @@ -69,14 +69,16 @@ static inline int cvm_oct_check_rcv_error(struct >> cvmx_

Re: [PATCH] stating: octeon: Drop on uncorrectable alignment or FCS error

2020-10-09 Thread Dan Carpenter
On Fri, Oct 09, 2020 at 11:46:05AM +0200, Alexander A Sverdlin wrote: > --- a/drivers/staging/octeon/ethernet-rx.c > +++ b/drivers/staging/octeon/ethernet-rx.c > @@ -69,14 +69,16 @@ static inline int cvm_oct_check_rcv_error(struct cvmx_wqe > *work) > else > port = work->word1.c

[PATCH] stating: octeon: Drop on uncorrectable alignment or FCS error

2020-10-09 Thread Alexander A Sverdlin
From: Alexander Sverdlin Currently in case of alignment or FCS error if the packet cannot be corrected it's still not dropped. Report the error properly and drop the packet while making the code around a little bit more readable. Signed-off-by: Alexander Sverdlin Fixes: 80ff0fd3ab ("Staging: Ad