On Mon, 2006-04-10 at 15:04 +0100, Daniel Drake wrote:
> I think netif_stop_queue() is only supposed to be used directly from
> inside a hard_start_xmit function. I think we should be using
> netif_disable_tx() here.
Looks about right to me, since that actually does a spinlock :)
I'll send a n
Johannes Berg wrote:
Seems we forgot to stop the queue while scanning. Better do that so we
don't transmit packets all the time during background scanning.
Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
--- a/net/ieee80211/softmac/ieee80211softmac_scan.c
+++ b/net/ieee80211/softmac/ieee80211s
On Sun, 2006-04-09 at 15:17 +1000, Herbert Xu wrote:
> Right. You can't stop the queue for a period longer than the watchdog
> timeout (default is 5s) on the device. In fact there is a bug here in
> that neither bcm43xx nor the softmac layer is setting trans_start.
Hah. Alright, I'll look into
Johannes Berg <[EMAIL PROTECTED]> wrote:
>
> Yeah, thanks. I had realised that a while later but it was too late.
> Note that this blows up for me anyway so don't apply:
>
> [ 416.448315] SoftMAC: Start scanning with channel: 1
> [ 416.448331] SoftMAC: Scanning 14 channels
> [ 416.495245] NETD
On Sat, 2006-04-08 at 13:33 +1000, Herbert Xu wrote:
> Please use netif_wake_queue as otherwise packets can get stuck for quite
> a while.
Yeah, thanks. I had realised that a while later but it was too late.
Note that this blows up for me anyway so don't apply:
[ 416.448315] SoftMAC: Start scan
Johannes Berg <[EMAIL PROTECTED]> wrote:
>
> @@ -239,6 +259,7 @@ void ieee80211softmac_scan_finished(stru
>if (net)
>sm->set_channel(sm->dev, net->channel);
>}
> + netif_start_queue(sm->ieee->dev);
Please use netif_wake_queue as otherwise packe
Seems we forgot to stop the queue while scanning. Better do that so we
don't transmit packets all the time during background scanning.
Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
--- a/net/ieee80211/softmac/ieee80211softmac_scan.c
+++ b/net/ieee80211/softmac/ieee80211softmac_scan.c
@@ -47,6
