Re: [PATCH] softmac: Fixed handling of deassociation from AP

2006-12-07 Thread Michael Buesch
On Thursday 07 December 2006 01:36, Larry Finger wrote: > it seems to > me that the mutex protects only the association data; whereas the spinlock > protects more data, but > does include the association data. Nope. The same way you could argue that the BKL should be taken here, as it's "the g

Re: [PATCH] softmac: Fixed handling of deassociation from AP

2006-12-06 Thread Larry Finger
Michael Buesch wrote: On Wednesday 06 December 2006 22:51, Ulrich Kunitz wrote: On 06-12-06 21:52 Michael Buesch wrote: On Wednesday 06 December 2006 21:17, Ulrich Kunitz wrote: On 06-12-06 18:52 Michael Buesch wrote: All data in mac->associnfo is protected by mac->associnfo->mutex and _not

Re: [PATCH] softmac: Fixed handling of deassociation from AP

2006-12-06 Thread Michael Buesch
On Wednesday 06 December 2006 22:51, Ulrich Kunitz wrote: > On 06-12-06 21:52 Michael Buesch wrote: > > > On Wednesday 06 December 2006 21:17, Ulrich Kunitz wrote: > > > On 06-12-06 18:52 Michael Buesch wrote: > > > > > > > All data in mac->associnfo is protected by mac->associnfo->mutex > > > >

Re: [PATCH] softmac: Fixed handling of deassociation from AP

2006-12-06 Thread Ulrich Kunitz
On 06-12-06 21:52 Michael Buesch wrote: > On Wednesday 06 December 2006 21:17, Ulrich Kunitz wrote: > > On 06-12-06 18:52 Michael Buesch wrote: > > > > > All data in mac->associnfo is protected by mac->associnfo->mutex > > > and _not_ mac->lock. > > > > Are you sure? > > Yes I am. > > > One ca

Re: [PATCH] softmac: Fixed handling of deassociation from AP

2006-12-06 Thread Michael Buesch
On Wednesday 06 December 2006 21:17, Ulrich Kunitz wrote: > On 06-12-06 18:52 Michael Buesch wrote: > > > All data in mac->associnfo is protected by mac->associnfo->mutex > > and _not_ mac->lock. > > Are you sure? Yes I am. > One can find for instance the following function in > ieee80211softm

Re: [PATCH] softmac: Fixed handling of deassociation from AP

2006-12-06 Thread Ulrich Kunitz
On 06-12-06 18:52 Michael Buesch wrote: > All data in mac->associnfo is protected by mac->associnfo->mutex > and _not_ mac->lock. Are you sure? One can find for instance the following function in ieee80211softmac_assoc.c: void ieee80211softmac_disassoc(struct ieee80211softmac_device *mac) {

Re: [PATCH] softmac: Fixed handling of deassociation from AP

2006-12-06 Thread Michael Buesch
On Wednesday 06 December 2006 15:45, Larry Finger wrote: > From: Ulrich Kunitz <[EMAIL PROTECTED]> > > A deauthentication from the AP doesn't start a reassociation by > SoftMAC. To fix this mac->associnfo.associating must be set and the > ieee80211softmac_assoc_work function must be scheduled. >

[PATCH] softmac: Fixed handling of deassociation from AP

2006-12-06 Thread Larry Finger
From: Ulrich Kunitz <[EMAIL PROTECTED]> A deauthentication from the AP doesn't start a reassociation by SoftMAC. To fix this mac->associnfo.associating must be set and the ieee80211softmac_assoc_work function must be scheduled. Signed-off-by: Ulrich Kunitz <[EMAIL PROTECTED]> Signed-off-by: Lar

[PATCH] softmac: Fixed handling of deassociation from AP

2006-12-03 Thread Ulrich Kunitz
In 2.6.19 a deauthentication from the AP doesn't start a reassociation by the softmac code. It appears that mac->associnfo.associating must be set and the ieee80211softmac_assoc_work function must be scheduled. This patch fixes that. Signed-off-by: Ulrich Kunitz <[EMAIL PROTECTED]> --- net/ieee80