Re: [PATCH] sock_diag: fix autoloading of the raw_diag module

2018-11-05 Thread David Miller
From: Andrei Vagin Date: Sun, 4 Nov 2018 22:37:15 -0800 > IPPROTO_TCP isn't registred as an inet protocol, so > inet_protos[protocol] is always NULL for it. > > Cc: Cyrill Gorcunov > Cc: Xin Long > Fixes: bf2ae2e4bf93 ("sock_diag: request _diag module only when the family or > proto has been

Re: [PATCH] sock_diag: fix autoloading of the raw_diag module

2018-11-05 Thread Cyrill Gorcunov
On Mon, Nov 05, 2018 at 10:12:34AM +0300, Cyrill Gorcunov wrote: > > Andrew, looking into kernel code I wonder, maybe we should simply > add this protocol into inet_protos during net/ipv4/af_inet.c:inet_init? > It will require to add netns_ok into raw_prot of course. After spending some time on t

Re: [PATCH] sock_diag: fix autoloading of the raw_diag module

2018-11-04 Thread Cyrill Gorcunov
On Sun, Nov 04, 2018 at 10:37:15PM -0800, Andrei Vagin wrote: > IPPROTO_TCP isn't registred as an inet protocol, so > inet_protos[protocol] is always NULL for it. Typo, IPPROTO_RAW > > Cc: Cyrill Gorcunov > Cc: Xin Long > Fixes: bf2ae2e4bf93 ("sock_diag: request _diag module only when the fami

[PATCH] sock_diag: fix autoloading of the raw_diag module

2018-11-04 Thread Andrei Vagin
IPPROTO_TCP isn't registred as an inet protocol, so inet_protos[protocol] is always NULL for it. Cc: Cyrill Gorcunov Cc: Xin Long Fixes: bf2ae2e4bf93 ("sock_diag: request _diag module only when the family or proto has been registered") Signed-off-by: Andrei Vagin --- net/core/sock.c | 1 + 1