From: Herbert Xu <[EMAIL PROTECTED]>
Date: Tue, 7 Feb 2006 22:21:37 +1100
> [NET]: Replace skb_pull/skb_postpull_rcsum with skb_pull_rcsum
>
> We're now starting to have quite a number of places that do skb_pull
> followed immediately by an skb_postpull_rcsum. We can merge these
> two operations
On Fri, Feb 03, 2006 at 10:01:17AM -0800, Stephen Hemminger wrote:
>
> static unsigned char *skb_pull_rcsum(struct sk_buff *skb, unsigned int len)
> {
> if (unlikely(len > skb->len))
> return NULL;
> if (skb->ip_summed == CHECKSUM_HW)
> skb->csum = csum_sub(
On Thu, 02 Feb 2006 22:24:27 -0800 (PST)
"David S. Miller" <[EMAIL PROTECTED]> wrote:
> From: Herbert Xu <[EMAIL PROTECTED]>
> Date: Fri, 03 Feb 2006 12:26:32 +1100
>
> > David S. Miller <[EMAIL PROTECTED]> wrote:
> > >
> > > This patch made me notice that the length is sort of implicit
> > > or
On Thu, 02 Feb 2006 22:24:27 -0800 (PST)
"David S. Miller" <[EMAIL PROTECTED]> wrote:
> From: Herbert Xu <[EMAIL PROTECTED]>
> Date: Fri, 03 Feb 2006 12:26:32 +1100
>
> > David S. Miller <[EMAIL PROTECTED]> wrote:
> > >
> > > This patch made me notice that the length is sort of implicit
> > > or
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Fri, 03 Feb 2006 12:26:32 +1100
> David S. Miller <[EMAIL PROTECTED]> wrote:
> >
> > This patch made me notice that the length is sort of implicit
> > or can be calculated given "start" and the current skb->data
> > value.
> >
> > Someone might want to
David S. Miller <[EMAIL PROTECTED]> wrote:
>
> This patch made me notice that the length is sort of implicit
> or can be calculated given "start" and the current skb->data
> value.
>
> Someone might want to look into making that simplification
> at some point.
Or we could simply merge skb_pull a
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Thu, 2 Feb 2006 16:32:31 -0800
> The SNAP code pops off it's 5 byte header, but doesn't adjust
> the checksum. This would cause problems when using device that
> does IP over SNAP and hardware receive checksums.
>
> Signed-off-by: Stephen Hemminge
The SNAP code pops off it's 5 byte header, but doesn't adjust
the checksum. This would cause problems when using device that
does IP over SNAP and hardware receive checksums.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
--- br-2.6.orig/net/802/psnap.c
+++ br-2.6/net/802/psnap.c
@@ -59,8
