Re: [PATCH] smsc95xx: Add support for automated PHY address detection

2018-12-23 Thread Marek Vasut
On 12/23/18 11:56 AM, Andrew Lunn wrote: > On Sun, Dec 23, 2018 at 11:43:05AM +0100, Marek Vasut wrote: >> On 12/23/18 11:23 AM, Andrew Lunn wrote: > +static int smsc95xx_phy_address(struct usbnet *dev) > +{ > + u32 read_buf; > + int ret, id1, id2, phyad; > + > + ret = smsc9

Re: [PATCH] smsc95xx: Add support for automated PHY address detection

2018-12-23 Thread Andrew Lunn
On Sun, Dec 23, 2018 at 11:43:05AM +0100, Marek Vasut wrote: > On 12/23/18 11:23 AM, Andrew Lunn wrote: > >>> +static int smsc95xx_phy_address(struct usbnet *dev) > >>> +{ > >>> + u32 read_buf; > >>> + int ret, id1, id2, phyad; > >>> + > >>> + ret = smsc95xx_read_reg(dev, HW_CFG, &read_buf); > >>>

Re: [PATCH] smsc95xx: Add support for automated PHY address detection

2018-12-23 Thread Marek Vasut
On 12/23/18 11:23 AM, Andrew Lunn wrote: >>> +static int smsc95xx_phy_address(struct usbnet *dev) >>> +{ >>> + u32 read_buf; >>> + int ret, id1, id2, phyad; >>> + >>> + ret = smsc95xx_read_reg(dev, HW_CFG, &read_buf); >>> + if (ret < 0) >>> + return ret; >>> + >>> + /* Check if

Re: [PATCH] smsc95xx: Add support for automated PHY address detection

2018-12-23 Thread Andrew Lunn
> > +static int smsc95xx_phy_address(struct usbnet *dev) > > +{ > > + u32 read_buf; > > + int ret, id1, id2, phyad; > > + > > + ret = smsc95xx_read_reg(dev, HW_CFG, &read_buf); > > + if (ret < 0) > > + return ret; > > + > > + /* Check if using external PHY, if not, use internal

Re: [PATCH] smsc95xx: Add support for automated PHY address detection

2018-12-23 Thread Marek Vasut
On 9/11/18 12:12 PM, Marek Vasut wrote: > The SMSC95xx chip can use either the internal PHY or an external one. > Currently, the driver hard-codes support for the internal PHY only. > > This patch reads out the HW_CFG register to determine whether external > PHY is attached or not. If an external