Re: [PATCH] sir: switch to a workqueue

2006-04-15 Thread Christoph Hellwig
On Sat, Apr 15, 2006 at 04:24:15PM +0200, Martin Diehl wrote: > > My only concern with this patch is this: <..> > Hm, queue_work might fail (like it was possible with irda_queue_request), > if work->pending is set. In that case, chances are we have a partially > configured irda device dangling

Re: [PATCH] sir: switch to a workqueue

2006-04-14 Thread Jean Tourrilhes
On Fri, Apr 14, 2006 at 08:20:15PM +0200, Christoph Hellwig wrote: > sir_kthread.c pretty much duplicates the workqueue functionality. > Switch it to use a workqueue instead. It could probably use > schedule_work/schedule_delayed_work instead of having it's own > waitqueue, but I'd rather leave th

[PATCH] sir: switch to a workqueue

2006-04-14 Thread Christoph Hellwig
sir_kthread.c pretty much duplicates the workqueue functionality. Switch it to use a workqueue instead. It could probably use schedule_work/schedule_delayed_work instead of having it's own waitqueue, but I'd rather leave that to the maintainer. The file should probably get a name that still makes