Re: [PATCH] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event

2020-05-25 Thread Marcelo Ricardo Leitner
On Mon, May 25, 2020 at 10:49:06PM +0200, Jonas Falkevik wrote: > On Mon, May 25, 2020 at 6:10 PM Xin Long wrote: > > > > On Mon, May 25, 2020 at 9:10 PM Marcelo Ricardo Leitner > > wrote: > > > > > > On Mon, May 25, 2020 at 04:42:16PM +0800, Xin Long wrote: > > > > On Sat, May 23, 2020 at 8:04 P

Re: [PATCH] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event

2020-05-25 Thread Jonas Falkevik
On Mon, May 25, 2020 at 6:10 PM Xin Long wrote: > > On Mon, May 25, 2020 at 9:10 PM Marcelo Ricardo Leitner > wrote: > > > > On Mon, May 25, 2020 at 04:42:16PM +0800, Xin Long wrote: > > > On Sat, May 23, 2020 at 8:04 PM Jonas Falkevik > > > wrote: > > > > > > > > On Tue, May 19, 2020 at 10:42

Re: [PATCH] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event

2020-05-25 Thread Xin Long
On Mon, May 25, 2020 at 9:10 PM Marcelo Ricardo Leitner wrote: > > On Mon, May 25, 2020 at 04:42:16PM +0800, Xin Long wrote: > > On Sat, May 23, 2020 at 8:04 PM Jonas Falkevik > > wrote: > > > > > > On Tue, May 19, 2020 at 10:42 PM Marcelo Ricardo Leitner > > > wrote: > > > > > > > > On Fri, Ma

Re: [PATCH] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event

2020-05-25 Thread Marcelo Ricardo Leitner
On Mon, May 25, 2020 at 04:42:16PM +0800, Xin Long wrote: > On Sat, May 23, 2020 at 8:04 PM Jonas Falkevik > wrote: > > > > On Tue, May 19, 2020 at 10:42 PM Marcelo Ricardo Leitner > > wrote: > > > > > > On Fri, May 15, 2020 at 10:30:29AM +0200, Jonas Falkevik wrote: > > > > On Wed, May 13, 2020

Re: [PATCH] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event

2020-05-25 Thread Xin Long
On Sat, May 23, 2020 at 8:04 PM Jonas Falkevik wrote: > > On Tue, May 19, 2020 at 10:42 PM Marcelo Ricardo Leitner > wrote: > > > > On Fri, May 15, 2020 at 10:30:29AM +0200, Jonas Falkevik wrote: > > > On Wed, May 13, 2020 at 11:32 PM Marcelo Ricardo Leitner > > > wrote: > > > > > > > > On Wed,

Re: [PATCH] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event

2020-05-23 Thread Jonas Falkevik
On Tue, May 19, 2020 at 10:42 PM Marcelo Ricardo Leitner wrote: > > On Fri, May 15, 2020 at 10:30:29AM +0200, Jonas Falkevik wrote: > > On Wed, May 13, 2020 at 11:32 PM Marcelo Ricardo Leitner > > wrote: > > > > > > On Wed, May 13, 2020 at 10:11:05PM +0200, Jonas Falkevik wrote: > > > > On Wed, M

Re: [PATCH] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event

2020-05-19 Thread Marcelo Ricardo Leitner
On Fri, May 15, 2020 at 10:30:29AM +0200, Jonas Falkevik wrote: > On Wed, May 13, 2020 at 11:32 PM Marcelo Ricardo Leitner > wrote: > > > > On Wed, May 13, 2020 at 10:11:05PM +0200, Jonas Falkevik wrote: > > > On Wed, May 13, 2020 at 6:01 PM Marcelo Ricardo Leitner > > > wrote: > > > > > > > > On

Re: [PATCH] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event

2020-05-15 Thread Jonas Falkevik
On Wed, May 13, 2020 at 11:32 PM Marcelo Ricardo Leitner wrote: > > On Wed, May 13, 2020 at 10:11:05PM +0200, Jonas Falkevik wrote: > > On Wed, May 13, 2020 at 6:01 PM Marcelo Ricardo Leitner > > wrote: > > > > > > On Wed, May 13, 2020 at 04:52:16PM +0200, Jonas Falkevik wrote: > > > > Do not gen

Re: [PATCH] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event

2020-05-13 Thread Marcelo Ricardo Leitner
On Wed, May 13, 2020 at 10:11:05PM +0200, Jonas Falkevik wrote: > On Wed, May 13, 2020 at 6:01 PM Marcelo Ricardo Leitner > wrote: > > > > On Wed, May 13, 2020 at 04:52:16PM +0200, Jonas Falkevik wrote: > > > Do not generate SCTP_ADDR_{MADE_PRIM,ADDED} events for SCTP_FUTURE_ASSOC > > > assocs. >

Re: [PATCH] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event

2020-05-13 Thread Jonas Falkevik
On Wed, May 13, 2020 at 6:01 PM Marcelo Ricardo Leitner wrote: > > On Wed, May 13, 2020 at 04:52:16PM +0200, Jonas Falkevik wrote: > > Do not generate SCTP_ADDR_{MADE_PRIM,ADDED} events for SCTP_FUTURE_ASSOC > > assocs. > > How did you get them? > I think one case is when receiving INIT chunk in

Re: [PATCH] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event

2020-05-13 Thread Marcelo Ricardo Leitner
On Wed, May 13, 2020 at 04:52:16PM +0200, Jonas Falkevik wrote: > Do not generate SCTP_ADDR_{MADE_PRIM,ADDED} events for SCTP_FUTURE_ASSOC > assocs. How did you get them? I'm thinking you're fixing a side-effect of another issue here. For example, in sctp_assoc_update(), it first calls sctp_asso

[PATCH] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event

2020-05-13 Thread Jonas Falkevik
Do not generate SCTP_ADDR_{MADE_PRIM,ADDED} events for SCTP_FUTURE_ASSOC assocs. These events are described in rfc6458#section-6.1 SCTP_PEER_ADDR_CHANGE: This tag indicates that an address that is part of an existing association has experienced a change of state (e.g., a failure or return to servi