Quoting David Howells :
Gustavo A. R. Silva wrote:
- resend_at = now + rxrpc_resend_timeout;
+ resend_at += now;
Yep. :-)
Great!
What about this one: https://lkml.org/lkml/2017/11/27/810
applies the same?
Thanks
--
Gustavo A. R. Silva
Gustavo A. R. Silva wrote:
> - resend_at = now + rxrpc_resend_timeout;
> + resend_at += now;
Yep. :-)
David
Hi David,
Quoting David Howells :
Gustavo A. R. Silva wrote:
Value assigned to variable resend_at is overwritten before it can be used.
Fix this by removing the value overwrite as it seems that this is a
leftover code.
NAK. Your fix will actually cause the code to break.
The resend_at v
Gustavo A. R. Silva wrote:
> Value assigned to variable resend_at is overwritten before it can be used.
>
> Fix this by removing the value overwrite as it seems that this is a
> leftover code.
NAK. Your fix will actually cause the code to break.
The resend_at value used for the timer must be
Value assigned to variable resend_at is overwritten before it can be used.
Fix this by removing the value overwrite as it seems that this is a
leftover code.
Addresses-Coverity-ID: 1462262
Fixes: beb8e5e4f38c ("rxrpc: Express protocol timeouts in terms of RTT")
Signed-off-by: Gustavo A. R. Silva
